update: uses_beamforming antenna attribute#214
Draft
artistrea wants to merge 1 commit intodevelopmentfrom
Draft
Conversation
This was referenced Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DONE:
The
select_uefunction does not live up to its name. It does not select ue's, it only creates the beamforming parameters. However, the current implementation is really slow for a big number of base stations, and it made the performance of simulations considerably worse.For example, when using MSS DC as IMT, there can be a LOT of active satellites per drop since constellations are big. 1 example drop performance stats:
Adding an attribute to completely skip adding beamforming vectors when they are not needed solves the current problem, since MSS DC considered does not use antenna array and doesn't do digital beamforming.
TODO:
More testing is needed with different parameters use cases. Not sure the current implementation doesn't normal macrocell/hotspot simulations.