Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/photo book #15

Merged
merged 13 commits into from
Apr 11, 2024
Merged

Feature/photo book #15

merged 13 commits into from
Apr 11, 2024

Conversation

bas-boop
Copy link
Member

@bas-boop bas-boop commented Apr 8, 2024

No description provided.

@bas-boop bas-boop added code A pull request that is code related. new New feature or improvement on something work in progress This pull request is in progress, not ready to be reviewed/tested labels Apr 8, 2024
@bas-boop bas-boop self-assigned this Apr 8, 2024
@bas-boop bas-boop added ready for review A code owner may review the pull request and removed work in progress This pull request is in progress, not ready to be reviewed/tested labels Apr 11, 2024
@bas-boop bas-boop marked this pull request as ready for review April 11, 2024 13:15
MartijnRene
MartijnRene approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@MartijnRene MartijnRene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Mooie code Bas :D

Assets/Scripts/Framework/PhoneCamera/PhotoInteractable.cs Show resolved Hide resolved
Assets/Scripts/Framework/PhoneCamera/PhotoInteractable.cs Outdated Show resolved Hide resolved
Assets/Scripts/UI/Canvas/PhotoBook/PhotoBook.cs Outdated Show resolved Hide resolved
@bas-boop bas-boop added ready for merge Pull request is ready to merge (don't forget to update from develop) and removed ready for review A code owner may review the pull request labels Apr 11, 2024
@bas-boop bas-boop merged commit 92e581c into develop Apr 11, 2024
1 check passed
@bas-boop bas-boop deleted the feature/photo-book branch April 11, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnRene MartijnRene MartijnRene approved these changes

@Wildeaso1 Wildeaso1 Wildeaso1 approved these changes

Assignees

@bas-boop bas-boop

Labels
code A pull request that is code related. new New feature or improvement on something ready for merge Pull request is ready to merge (don't forget to update from develop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bas-boop @Wildeaso1 @MartijnRene