-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update renovate config to handle all dependency types and group upgrades #3312
Conversation
b0188fe
to
e398cac
Compare
Size Change: 0 B Total Size: 946 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since renovate has had a longer support for groups and pnpm, I agree with going forward with renovate. Thank you for fixing the labelling (renovate PRs didn't have all the necessary labels before) and setting everything up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I prefer personally prefer Dependabot over Renovate, Renovate has clear advantages in our case and some features that we would like, so settling on one tool instead of two makes more sense. Thanks for this. The addition of the pre-commit hook is also a great touch, thanks!
I do have some questions and suggestions though.
Fixes
Fixes #3304 by @sarayourfriend
Closes https://github.com/WordPress/openverse-infrastructure/issues/484 by @sarayourfriend
Description
Updates the existing renovate configuration in the following ways:
This is one approach we could take. The other is, of course, to continue using dependabot. It has rudimentary support for pnpm and grouped dependencies, both added very recently, but it's a bit more of a chore to configure (lots of repeated labeling rules, for example) and tends to take a very long time to support new features (e.g., pnpm, grouped dependencies, sensible github action matching), if it ever gets them at all.
Testing Instructions
Not entirely sure. I suppose we can run the renovate workflow from this branch and see what happens.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin