-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD adaq42xx #1209
ADD adaq42xx #1209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation update on https://wiki.analog.com/resources/eval/ad4630-24-eval-board/ad4630-24-developer-guide or at docs/.
4ebfb78
to
7da23b8
Compare
v1:
|
7da23b8
to
e5a5ee3
Compare
e5a5ee3
to
427768c
Compare
Please update zed/readme file with new parameter, valid values and example(s) |
instead of using 0 and 1 to choose the device, could we try using the name? something like this:
We could use a variable like "DEVICE"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On top of these, I think the GitHub IO documentation should be added to this PR.
And at the end, maybe it would be good to have just two commits: one for the project and one for the documentation. Does it sound good?
427768c
to
1074779
Compare
d447966
to
c1da7f0
Compare
0221cf6
to
d4d5c13
Compare
…er supply Signed-off-by: Liviu Adace <liviu.adace@analog.com>
d4d5c13
to
744c0c7
Compare
Signed-off-by: Liviu Adace <liviu.adace@analog.com>
744c0c7
to
e2628cb
Compare
v2:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
* ad4630_fmc: Initial version of ADAQ4224 w/ and w/o fully isolated power supply Signed-off-by: Liviu Adace <liviu.adace@analog.com> * docs:ad4630_fmc: Add documentation for ADAQ4224 Signed-off-by: Liviu Adace <liviu.adace@analog.com> --------- Signed-off-by: Liviu Adace <liviu.adace@analog.com>
PR Description
Added initial version of adaq42xx with and without fully isolated power supply based on AD463x
PR Type
PR Checklist