Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD adaq42xx #1209

Merged
merged 2 commits into from
Apr 2, 2024
Merged

ADD adaq42xx #1209

merged 2 commits into from
Apr 2, 2024

Conversation

ladace
Copy link
Contributor

@ladace ladace commented Nov 3, 2023

PR Description

Added initial version of adaq42xx with and without fully isolated power supply based on AD463x

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projects/ad4630_fmc/zed/system_project.tcl Outdated Show resolved Hide resolved
projects/ad4630_fmc/zed/system_project.tcl Outdated Show resolved Hide resolved
projects/ad4630_fmc/zed/system_top_adaq42xx.v Outdated Show resolved Hide resolved
projects/ad4630_fmc/zed/system_top_adaq42xx.v Outdated Show resolved Hide resolved
projects/ad4630_fmc/common/ad463x_adaq42xx_bd.tcl Outdated Show resolved Hide resolved
@ladace ladace force-pushed the dev_adaq4224_main branch from 4ebfb78 to 7da23b8 Compare December 7, 2023 12:49
@ladace
Copy link
Contributor Author

ladace commented Dec 7, 2023

v1:

  • Reduced the number of files as requested by Adrian
  • Addressed the findings
  • Fixed the AD4030 and AD4630 xdc, sdi lines are is different for different number of used SDIs used

@sarpadi
Copy link
Contributor

sarpadi commented Jan 11, 2024

Please update zed/readme file with new parameter, valid values and example(s)

@sarpadi
Copy link
Contributor

sarpadi commented Jan 11, 2024

instead of using 0 and 1 to choose the device, could we try using the name?
https://github.com/analogdevicesinc/hdl/blob/dev_adaq4224_main/projects/ad4630_fmc/common/ad4x3x_bd.tcl#L95-L102

something like this:

switch $S_FPGA_CARRIER {
  ZCU102 {  ...  }
  K26I {  ...  }
  default { ... }
}

We could use a variable like "DEVICE"

make DEVICE=AD4630 etc

Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of these, I think the GitHub IO documentation should be added to this PR.
And at the end, maybe it would be good to have just two commits: one for the project and one for the documentation. Does it sound good?

projects/ad4630_fmc/common/ad463x_fmc.txt Outdated Show resolved Hide resolved
projects/ad4630_fmc/common/ad4x3x_bd.tcl Outdated Show resolved Hide resolved
projects/ad4630_fmc/common/adaq42xx_fmc.txt Show resolved Hide resolved
projects/ad4630_fmc/zed/Makefile Outdated Show resolved Hide resolved
projects/ad4630_fmc/zed/system_constr.tcl Outdated Show resolved Hide resolved
projects/ad4630_fmc/zed/system_constr.xdc Show resolved Hide resolved
projects/ad4630_fmc/zed/system_top.v Outdated Show resolved Hide resolved
@ladace ladace closed this Mar 7, 2024
@ladace ladace force-pushed the dev_adaq4224_main branch from 427768c to 1074779 Compare March 7, 2024 09:45
@ladace ladace reopened this Mar 12, 2024
@ladace ladace force-pushed the dev_adaq4224_main branch from d447966 to c1da7f0 Compare March 12, 2024 12:42
gastmaier
gastmaier previously approved these changes Mar 25, 2024
@ladace ladace requested a review from IuliaCMoldovan April 1, 2024 11:13
projects/ad4630_fmc/common/ad4030_fmc.txt Outdated Show resolved Hide resolved
docs/projects/ad4630_fmc/index.rst Show resolved Hide resolved
…er supply

Signed-off-by: Liviu Adace <liviu.adace@analog.com>
@ladace ladace force-pushed the dev_adaq4224_main branch from d4d5c13 to 744c0c7 Compare April 2, 2024 07:53
Signed-off-by: Liviu Adace <liviu.adace@analog.com>
@ladace ladace force-pushed the dev_adaq4224_main branch from 744c0c7 to e2628cb Compare April 2, 2024 07:56
@ladace
Copy link
Contributor Author

ladace commented Apr 2, 2024

v2:

  • Addressed and fixed comments

Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@ladace ladace merged commit 393a1f6 into main Apr 2, 2024
1 of 3 checks passed
@ladace ladace deleted the dev_adaq4224_main branch April 2, 2024 11:50
ladace added a commit that referenced this pull request Jun 13, 2024
* ad4630_fmc: Initial version of ADAQ4224 w/ and w/o fully isolated power supply

Signed-off-by: Liviu Adace <liviu.adace@analog.com>

* docs:ad4630_fmc: Add documentation for ADAQ4224

Signed-off-by: Liviu Adace <liviu.adace@analog.com>

---------

Signed-off-by: Liviu Adace <liviu.adace@analog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants