-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35007] Add support for Flink 1.19 #90
Merged
MartijnVisser
merged 3 commits into
apache:main
from
MartijnVisser:flink-35007-add-119-support
Apr 11, 2024
Merged
[FLINK-35007] Add support for Flink 1.19 #90
MartijnVisser
merged 3 commits into
apache:main
from
MartijnVisser:flink-35007-add-119-support
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60cd208
to
6bd416d
Compare
This also includes dropping the weekly tests for the `v3.0` branch, since `v3.1` has been released and that's our main version going forward.
6bd416d
to
5617ee8
Compare
uce
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the fallback for flink-conf.yaml
.
5617ee8
to
eec5437
Compare
c2fe299
to
0c92ff2
Compare
…thon tests work for Flink 1.x releases
e6957c6
to
f8a59f6
Compare
uce
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Fantastic!
MartijnVisser
added a commit
to MartijnVisser/flink-connector-kafka
that referenced
this pull request
Apr 11, 2024
* [FLINK-35007] Add support for Flink 1.19 This also includes dropping the weekly tests for the `v3.0` branch, since `v3.1` has been released and that's our main version going forward. * [FLINK-35007] Remove unused test class that relied on removed Internal class * [FLINK-35007][ci] Copy old `flink-conf.yaml` to make sure that all Python tests work for Flink 1.x releases (cherry picked from commit 897001d)
MartijnVisser
added a commit
that referenced
this pull request
Apr 11, 2024
* [FLINK-35007] Add support for Flink 1.19 This also includes dropping the weekly tests for the `v3.0` branch, since `v3.1` has been released and that's our main version going forward. * [FLINK-35007] Remove unused test class that relied on removed Internal class * [FLINK-35007][ci] Copy old `flink-conf.yaml` to make sure that all Python tests work for Flink 1.x releases (cherry picked from commit 897001d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes dropping the weekly tests for the
v3.0
branch, sincev3.1
has been released and that's our main version going forward.