feat(docker): install CUDA drivers in autoware:base image
#5159
Conversation
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
added
type:containers
|
With this change, the image sizes of
|
| ENV CCACHE_DIR="/root/.ccache" | ||
|
|
||
| # Set up development environment | ||
| RUN --mount=type=ssh \ | ||
| --mount=type=cache,target=/var/cache/apt,sharing=locked \ | ||
| ./setup-dev-env.sh -y --module all ${SETUP_ARGS} --no-cuda-drivers openadkit \ | ||
| ./setup-dev-env.sh -y --module all openadkit \ |
There was a problem hiding this comment.
@youtalk this command will not run the autoware.dev_env.cuda role.
The autoware.dev_env.cuda will only run if module == 'base' and prompt_install_nvidia=='y'.
Is it possible that there is a bug here?
There was a problem hiding this comment.
This PR changed the Dockerfile to install CUDA drivers on base stage.
There was a problem hiding this comment.
@youtalk what is misleading is the argument --no-cuda-drivers which implies that there are no CUDA drivers?.
There was a problem hiding this comment.
--no-nvidia or "" are given by SETUP_ARGS.
https://github.com/autowarefoundation/autoware/blob/main/.github/workflows/docker-build-and-push.yaml#L28
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Description
Based on the feedback from https://github.com/orgs/autowarefoundation/discussions/5110#discussioncomment-10469371, this PR will create an
autoware:base-cudaimage that installs the CUDA drivers on thebasestage. By installing several gigabytes of CUDA drivers in the top stage of the Dockerfile, the build cache will be utilized more effectively, making thedocker pullcache easier to leverage.Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/10667352309
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.