Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Region S3 Client #52

Closed
millems opened this issue Jul 6, 2017 · 12 comments
Closed

Cross-Region S3 Client #52

millems opened this issue Jul 6, 2017 · 12 comments
Labels
1.x Parity feature-request A feature should be added or improved. no-auto-closure p1 This is a high priority issue

Comments

@millems
Copy link
Contributor

millems commented Jul 6, 2017

The 1.11.x S3 client automatically routed requests to the correct bucket region in a complicated manner. The 2.0.x client does not perform this automatic re-routing.

We should create a wrapper to pool S3 clients for different regions and automatically route requests to the region in which the bucket was created.

@manasshukla
Copy link

Is there an update on when this feature would be shipped out ?

@millems
Copy link
Contributor Author

millems commented Sep 25, 2020

Sorry, no update.

It's not our #1 priority, because with access points and other arn-based ways of accessing buckets/objects plus the use-arn-region flag, the SDK will automatically route the request to the correct region without the overhead of an extra call to AWS to find out where the bucket actually is.

I understand there's still value in this feature request, since the caller may not have a full bucket ARN.

@byF
Copy link

byF commented Jul 22, 2021

If anyone thinks using ARNs like arn:aws:s3:::mybucket will work, they won't #2244

@pkgonan
Copy link

pkgonan commented Nov 28, 2021

@millems Hi. Any plan of supporting this feature ? A lot of people think they need this feature from the perspective of customers using AWS S3 products.

@millems
Copy link
Contributor Author

millems commented Nov 30, 2021

At some point, probably, but in the meantime you could try using access points which automatically support cross-region request routing.

@pkgonan
Copy link

pkgonan commented Dec 1, 2021

@millems
Oh. That's good news. When are you expecting?

@millems
Copy link
Contributor Author

millems commented Dec 1, 2021

@pkgonan Unfortunately we have no expected date to report at this time.

@pkgonan
Copy link

pkgonan commented Dec 1, 2021

@millems Thanks for your reply. :)

@maciejwalkowiak
Copy link

maciejwalkowiak commented Mar 24, 2022

FYI we are working on adding cross-region S3 client to Spring Cloud AWS. It's early stage but looks promising so far: https://github.com/awspring/spring-cloud-aws/blob/3.0.x-s3/spring-cloud-aws-s3-parent/spring-cloud-aws-s3/src/main/java/io/awspring/cloud/s3/CrossRegionS3Client.java

Basic idea is that every region-specific method is wrapped in a try catch that on http status 301 uses client created for the region where the bucket got created. Clients are cached both by region and also by bucket name (to speed up subsequent calls for the same bucket). Implementation is a bit Spring specific as we use LRU cache from spring-core, but if needed this can be replaced with something else or abstracted out.

Repetitive chunk of this class is generated with JavaParser. If you're interested this is a very sketchy implementation:

@zoewangg
Copy link
Contributor

This feature has been released in 2.20.99. You can enable it by setting crossRegionAccessEnabled to true on the S3 client builder.
Example:

S3AsyncClient client = S3AsyncClient.builder()
                                    .crossRegionAccessEnabled(true)
                                    .build();

I'll go ahead and close this issue. As always, feedback is welcome! :)

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dasmowenator
Copy link

So the addition of .crossRegionAccessEnabled(true) is nice... but it still doesn't work with opt-in regions, even if your account is opted into the given region. For example, if I create an S3 client in the us-east-1 region and then try to head an object in an af-south-1 bucket that I own, it will result in a 400 error. Or if I create an S3 client in the af-south-1 region and then try to head an object in an us-east-1 bucket that I own, it will also result in a 400 error. The SDKv1 client didn't have this problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Parity feature-request A feature should be added or improved. no-auto-closure p1 This is a high priority issue
Projects
None yet
Development

No branches or pull requests

9 participants