Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry RequestTimeout error by S3. #457

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Retry RequestTimeout error by S3. #457

merged 2 commits into from
Oct 16, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Oct 16, 2024

Description of changes:

  • S3 can kill the request with a 400 status code and the error code RequestTimeout. We should retry the request since other SDKs also treat this error as retryable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (ab70f74) to head (934f3e9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   89.30%   89.73%   +0.42%     
==========================================
  Files          20       20              
  Lines        6132     6154      +22     
==========================================
+ Hits         5476     5522      +46     
+ Misses        656      632      -24     
Files with missing lines Coverage Δ
source/s3.c 98.46% <ø> (ø)
source/s3_util.c 97.16% <100.00%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes

@waahm7 waahm7 merged commit 1670150 into main Oct 16, 2024
31 checks passed
@waahm7 waahm7 deleted the retry-request-timeout branch October 16, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants