Update description and bringup generated files to be also applicable to mobile robots. Update generated documenation in README files. Add templates for simulation and moveit setup. #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nibanovic
reviewed
Mar 26, 2024
destogl
commented
Apr 2, 2024
Nibanovic
previously approved these changes
Apr 3, 2024
Contributor
Nibanovic
left a comment
Nibanovic
left a comment
There was a problem hiding this comment.
All of the changes look okay.
As for my comments about robot_moveit.launch.py and the yaml parameter structure, @riyan-jose and I will update it in the following PR when we create a rtw-setup-moveit-config package template
muritane
reviewed
Apr 3, 2024
muritane
reviewed
Apr 3, 2024
|
This pull request is in conflict. Could you fix it @destogl? |
destogl
force-pushed
the
update-description-and-bringup-generators
branch
from
31eaa12 to
df0e404
Compare
…to mobile robots. Update generated documenation in README files. Add templates for simulation and moveit setup.
Co-authored-by: Daniel Azanov <31107191+muritane@users.noreply.github.com>
Co-authored-by: Daniel Azanov <31107191+muritane@users.noreply.github.com>
destogl
force-pushed
the
update-description-and-bringup-generators
branch
from
ea83c33 to
c0a6626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.