[Asset Selection] Make submitting an invalid query with only a single value convert to a key substring filter. #28435
+77
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellendag
approved these changes
Mar 12, 2025
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit cf6252c. |
salazarm
added a commit
that referenced
this pull request
Mar 12, 2025
… value convert to a key substring filter. (#28435) ## Summary & Motivation A lot of users are using their muscle memory and doing: 1. Type partial asset key 2. Hit enter 3. Error -> No results 4. Give up. Lets just do the right thing for these users by automatically converting their invalid query into a valid one! ## How I Tested these changes https://github.com/user-attachments/assets/f8533af6-81db-4b38-8e2e-ed2a6e18640e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
A lot of users are using their muscle memory and doing:
Lets just do the right thing for these users by automatically converting their invalid query into a valid one!
How I Tested these changes
Screen.Recording.2025-03-12.at.1.51.11.PM.mov