Merged
Conversation
msimberg
force-pushed
the
better-pack-unpack
branch
from
99fe0a0 to
d26c05a
Compare
msimberg
commented
Oct 27, 2025
|
|
||
| #define GHEX_UNSTRUCTURED_SERIALIZATION_THREADS_PER_BLOCK 32 | ||
| #define GHEX_UNSTRUCTURED_SERIALIZATION_THREADS_PER_BLOCK_X 32 | ||
| #define GHEX_UNSTRUCTURED_SERIALIZATION_THREADS_PER_BLOCK_Y 8 |
Contributor
Author
There was a problem hiding this comment.
I did a quick test with Y=1, and didn't see a major change in performance. I'd keep it at 8. In theory it should allow slightly better reuse of reading local_indices[idx], but the difference may be negligible.
boeschf
approved these changes
Nov 6, 2025
Collaborator
boeschf
left a comment
boeschf
left a comment
There was a problem hiding this comment.
Thank you, nice improvement. I am a bit wary about the submodule changes - maybe merge with master first to be sure.
Contributor
Author
|
@boeschf I've merged latest master now. I think the test failures are the same as on master? |
msimberg
force-pushed
the
better-pack-unpack
branch
from
1de545a to
411029e
Compare
Contributor
Author
|
I've merged main after the formatting changes. This should again be ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This parallelizes the packing/unpacking over
levelsin addition toindices. This also introduces two separate kernels for levels first/levels last as the access patterns are different.This is on top of #182, not because it depends on it, but simply because it's easier to test both changes in one branch.