Add namespace suggestions #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafal-gorecki
force-pushed
the
add-namespace-suggestions
branch
from
35ceb66 to
1fb0a56
Compare
delihus
requested changes
Jan 30, 2024
rafal-gorecki
force-pushed
the
add-namespace-suggestions
branch
from
855805d to
066ae9b
Compare
delihus
requested changes
Jan 30, 2024
rosbot_xl_controller/test/test_namespaced_diff_drive_controllers.py
Outdated
Show resolved
Hide resolved
rosbot_xl_controller/test/test_namespaced_mecanum_controllers.py
Outdated
Show resolved
Hide resolved
Merged
delihus
reviewed
Jan 31, 2024
rafal-gorecki
commented
Jan 31, 2024
Co-authored-by: Jakub Delicat <109142865+delihus@users.noreply.github.com>
rafal-gorecki
commented
Jan 31, 2024
rafal-gorecki
commented
Jan 31, 2024
delihus
requested changes
Jan 31, 2024
delihus
approved these changes
Jan 31, 2024
rafal-gorecki
added a commit
that referenced
this pull request
Jan 31, 2024
* added tf_prefixes to the urdf Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * add namespace to world list Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * tf_prefix for controller Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added namespace in mecanum test Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added namespace to bringup Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added fixed namespaces to description and controller Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Updated worldlist Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added multirobot test to controllers Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added rosbot_xl_bringup multirobot test Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * fixed .repos Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * updated submodules Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * updated industrial Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * first simulation launch Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * moved remapings to the urdf of intel Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * updated submodules Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added tf fixer | remapped pointcloud topic in .yaml Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added astra Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added zed Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added namespaced velodyne Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added remappings for velodyne Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added tests from rosbot_ros | fixed imu Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * add to the worldlist Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * lint | added multirobot simulation tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added multirobot tests | added tf_ros2_py dependency to the rosbot_ros Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * fixed xacro test Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * fixed removeing gz tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * created src insisde industrial ci Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * removed geometry2 Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update industrial_ci.yaml * added psutil dep Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added psutil dep Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * added psutil dep Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * formatted package.xml files | removed one robot from controller tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * updated package.xml in rosbot_xl_description Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * updated tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Removed multirobot tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Removed multirobot tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Revert "Removed multirobot tests" This reverts commit 30cf4c9. * Added delayed spawn for controllers Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added spawner to worldlist Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * bringup and controllers passes industrial Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Testing gazebo Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * industrial passes Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Passing industrial tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * removed comments Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Added bringup and controller tests Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * typo Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Update test_multirobot_controllers.py * updated repos Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * rosbot_hardware_interfaces main to ros2 Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> * Add namespace suggestions (#60) * Workflow merge many steps and pre-commit * test bringup refactor * test controller refactor * test * New tests * typo * 2024 Husarion copyright * Jakub suggestions * revert older version of black * Add info * Next suggestions * spell fix * remove sleep * remove submodule * debug fix * timeout increase * Apply suggestions from code review Co-authored-by: Jakub Delicat <109142865+delihus@users.noreply.github.com> * Apply suggestions from code review * Update .github/workflows/bump_version.yaml --------- Co-authored-by: Jakub Delicat <109142865+delihus@users.noreply.github.com> --------- Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com> Co-authored-by: rafal-gorecki <126687345+rafal-gorecki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.