Add front-end warnings and Inequality integration for new Chemistry options #1165
+147
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
- Coverage 36.46% 36.44% -0.03%
==========================================
Files 435 435
Lines 19290 19308 +18
Branches 6348 6344 -4
==========================================
+ Hits 7035 7036 +1
- Misses 11617 12234 +617
+ Partials 638 38 -600 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 4, 2024
jacbn
approved these changes
Oct 14, 2024
| @@ -89,7 +90,7 @@ export function generateMathsBasicFunctionsItems(): MenuItemProps[] { | |||
| ]; | |||
| } | |||
|
|
|||
| export function generateMathsTrigFunctionItem(name: string): MenuItemProps { | |||
| export function generateMathsTrigFunctionItem(name: string): MenuItemProps { // ohh heck | |||
There was a problem hiding this comment.
this is the general vibe inequality gives off...
There was a problem hiding this comment.
😔 You're making me tempted to keep it
jacbn
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option for coefficient scaling:
2 H2 + O2 -> 2 H2O===>>>H2 + 1/2 O2 -> H2Oand for disabling certain "available symbols" such as is done with trig functions for Symbolic Maths questions.
_state_symbolscontrols(s), (l), (g), (aq)Unavailable symbols are removed from the Inequality modal menu. If state symbols are unavailable and the user tries to use one in text-input, they are warned.
Both of these are not used as options for Nuclear Physics questions, although the logic is applied from available symbols to disallow state symbols, brackets, equilibrium arrows, and dots from its Inequality menu.
Also fixes a minor issue where processing the
_no_alphabetmeta symbol would skip the next meta symbol from being processed. The only place I could find this impacting was here (note the "_trigs" in the available symbols list).