Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): search reactoring, fixes, and new features #1890

Merged
merged 84 commits into from
May 21, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented May 13, 2024

Resolves #1650, resolves #1887, resolves #1494, resolves #1408, resolves #1950

Also overhauls search such that changes to filtering take place immediately, in the client.

https://search-refactor.loculus.org/

Remaining issues:

  • add back my sequences page
  • respect numeric inputs being only numeric
  • when making field invisible, unset rather than setting to ""
  • exclude hidden fields from download dialog
  • handle super long accession queries (state outside URL)
  • I had to disable two tests, I will add them back tracked by search: add back unit tests [by the end of this week] #1979, this week

@theosanderson theosanderson marked this pull request as draft May 13, 2024 15:46
@theosanderson theosanderson added the preview Triggers a deployment to argocd label May 15, 2024
@theosanderson theosanderson changed the title wip: search reactoring feat(website): search reactoring, fixes, and new features May 20, 2024
@theosanderson theosanderson marked this pull request as ready for review May 21, 2024 15:11
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! As discussed earlier: reviewing this would take a while but I'm happy to merge this already so that we have it for the beta testing.

@theosanderson theosanderson merged commit 3b19450 into main May 21, 2024
12 checks passed
@theosanderson theosanderson deleted the search-refactor branch May 21, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment