New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ReactDOM to use Html (which uses Buffers, not Printf) #156

Merged

davesnx merged 2 commits into main from use-html-instead-of-printf

Aug 7, 2024

Member

davesnx commented Aug 7, 2024 •

edited

Loading

Bring html_of_jsx's JSX module here and factor it
Remove "_onclick" hack since it's not used anymore
Use Html module in renderToString* and renderToLwtStream, making it probably x10 faster if not more. There are a tiny bit of allocations that we might be able to remove, but so far I have cleanup up most of them (for example Attribute.omit unsure if it allocates that unused string?)

davesnx added 2 commits

August 7, 2024 19:28


          Bring html_of_jsx into HTML module

6cbf601


          Refactor to remove Printf from ReactDOM and use Html.t

85dda39

davesnx mentioned this pull request

Remove all usages of Printf in native runtime davesnx/styled-ppx#503

Closed

davesnx merged commit c9883ab into main

2 checks passed

davesnx deleted the use-html-instead-of-printf branch

August 7, 2024 19:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet