iOS app

Fix VPN settings not being persisted #5211

Triggered via pull request September 9, 2024 14:09

rablador

opened #6772

fix-vpn-settings-not-being-persisted-ios-823

Status Success

Total duration 6m 29s

Billable time 7m

Artifacts –

ios.yml

on: pull_request

Annotations

18 warnings

Run swiftlint

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run swiftlint

swiftlint 0.56.2 is already installed and up-to-date. To reinstall 0.56.2, run: brew reinstall swiftlint

Run swiftlint: MullvadVPNTests/MullvadVPN/TunnelManager/TunnelManagerTests.swift#L118

Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines (function_body_length)

Run swiftlint: PacketTunnelCoreTests/PacketTunnelActorTests.swift#L213

SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)

Run swiftlint: PacketTunnelCore/Actor/PacketTunnelActor.swift#L283

Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines (function_body_length)

Check formatting

Unit tests

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Unit tests: --- xcodebuild#L1

Using the first of multiple matching destinations:

Unit tests: ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKitGo/wireguard.h#L26

umbrella header for module 'WireGuardKitGo' does not include header '/wireguard-go/maybenot/crates/maybenot-ffi/maybenot.h'

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

expected canonical name for private module 'MullvadRustRuntimeProxy' [-Wprivate-module]

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests

xcbeautify 2.11.0 is already installed and up-to-date. To reinstall 2.11.0, run: brew reinstall xcbeautify

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix VPN settings not being persisted #5211

Summary