Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] CMI estimators using forests #110

Closed
wants to merge 18 commits into from
Closed

[ENH] CMI estimators using forests #110

wants to merge 18 commits into from

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Aug 16, 2023

Supersedes: #94

Changes proposed in this pull request:

  • implements KSG estimator using scipy KDTree
  • implements KSG estimator using an unsupervised tree, which is validated on a Jupyter notebook

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Attention: 402 lines in your changes are missing coverage. Please review.

Comparison is base (386578a) 88.86% compared to head (64ddf97) 76.43%.

❗ Current head 64ddf97 differs from pull request most recent head dd4409f. Consider uploading reports for the commit dd4409f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #110       +/-   ##
===========================================
- Coverage   88.86%   76.43%   -12.43%     
===========================================
  Files          41       32        -9     
  Lines        3439     2521      -918     
===========================================
- Hits         3056     1927     -1129     
- Misses        383      594      +211     
Files Coverage Δ
sktree/experimental/__init__.py 100.00% <100.00%> (ø)
sktree/experimental/tests/test_monte_carlo.py 100.00% <100.00%> (ø)
sktree/utils.py 25.00% <25.00%> (ø)
sktree/experimental/tests/test_ksg.py 60.00% <60.00%> (ø)
sktree/experimental/mutual_info.py 33.33% <10.52%> (+12.82%) ⬆️
sktree/experimental/monte_carlo.py 69.11% <69.11%> (ø)
sktree/neighbors.py 58.58% <45.90%> (-27.63%) ⬇️
sktree/experimental/simulate.py 41.25% <8.33%> (-46.88%) ⬇️
sktree/experimental/forest.py 15.38% <15.38%> (ø)
sktree/experimental/ksg.py 17.12% <17.12%> (ø)

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant