Use pathogen-repo-build workflow for builds #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify build workflows by using the reusable Nextstrain pathogen-repo-build workflow. This does not update the fetch-and-ingest-branch workflow since that will require additional changes to support the custom configs. This does remove the `notify_pipeline_failed` step in the workflows. They can be added as a separate job in the workflow if we think they are still helpful.
|
IIUC, |
|
This looks good to me, I'll merge and bear in mind if it fails I've triggered a fetch-and-ingest to see if it all works out |
6 tasks
Yup, this was added to catch errors that were raised outside of the build itself. We should still get Slack notifications if there is an error during the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit is from @joverlee521, I just rebased it on master
Simplify build workflows by using the reusable Nextstrain pathogen-repo-build workflow.
This does not update the fetch-and-ingest-branch workflow since that will require additional changes to support the custom configs.
This does remove the
notify_pipeline_failedstep in the workflows. They can be added as a separate job in the workflow if we think they are still helpful.