Fix Asia weighted sampling #1150
Merged
Commits on Aug 26, 2024
-
Fix Asia 1m/2m temporal grouping
The temporal grouping attribute was changed from 'week' to 'year month' inadvertently in "Use population-based weighted sampling for Asia builds" (bc3f69e). Revert it back to 'week'.
-
Remove outdated comment on division grouping
This has been superseded by the following comment on country grouping with population size weights.
-
Simplify Asia subsampling scheme names
The grouping information is not necessary here and became inaccurate with the switch to country-based weighted sampling. It is only necessary for other regions to distinguish `nextstrain_region_grouped_by_country_*` from `nextstrain_region_grouped_by_division_*`.
-
Use population-based weighted sampling for 21L Asia builds
Follow-up to "Use population-based weighted sampling for Asia builds" (bc3f69e) and subsequent fixes. Those were only applied to the open and gisaid profiles, inadvertently skipping the gisaid-21L profile.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.