Remove PreviewOverlay when expanded #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all current usages of ExpandableTiles, it is possible for and sometimes even expected for users to interact with tiles by clicking. Having an invisible overlay on top of the last row of tiles with a separate onClick behavior can be confusing for users expecting another onClick behavior. When the tiles are expanded, the only benefit to having PreviewOverlay available is for the onClick behavior of hiding the tiles. This can already be accomplished by the ArrowButton which also covers full width and has a height of 1em. This removes the opacity transition, which in my eyes does not make a noticeable difference. The visually distinct part of the transition action is on the height change to show more rows of tiles, not the opacity here.
nextstrain-bot
temporarily deployed
to
nextstrain-s-victorlin--ljqwqo
|
Merging this because it worked well in my own testing and fixes a bug that would have impacted a new group 88c3092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all current usages of ExpandableTiles, it is possible for and sometimes even expected for users to interact with tiles by clicking. Having an invisible overlay on top of the last row of tiles with a separate onClick behavior can be confusing for users expecting another onClick behavior.
When the tiles are expanded, the only benefit to having PreviewOverlay available is for the onClick behavior of hiding the tiles. This can already be accomplished by the ArrowButton which also covers full width and has a height of 1em.
This removes the opacity transition, which in my eyes does not make a noticeable difference. The visually distinct part of the transition action is on the height change to show more rows of tiles, not the opacity here.
Related issues
Closes #1010
Checklist