Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PreviewOverlay when expanded #1006

Merged
merged 1 commit into from
Sep 11, 2024

Commits on Aug 28, 2024

  1. Remove PreviewOverlay when expanded

    In all current usages of ExpandableTiles, it is possible for and
    sometimes even expected for users to interact with tiles by clicking.
    Having an invisible overlay on top of the last row of tiles with a
    separate onClick behavior can be confusing for users expecting another
    onClick behavior.
    
    When the tiles are expanded, the only benefit to having PreviewOverlay
    available is for the onClick behavior of hiding the tiles. This can
    already be accomplished by the ArrowButton which also covers full width
    and has a height of 1em.
    
    This removes the opacity transition, which in my eyes does not make a
    noticeable difference. The visually distinct part of the transition
    action is on the height change to show more rows of tiles, not the
    opacity here.
    victorlin committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    18c66f1 View commit details
    Browse the repository at this point in the history