Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bootstrap v4 #958

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Commits on Jul 26, 2024

  1. Set container styles in one place

    Previously these were set in two places:
    
    1. the modified styled component
    2. bootstrap styles on `.container`
    
    Move all the relevant bootstrap styles into the modified styled
    component.
    victorlin committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    32229ad View commit details
    Browse the repository at this point in the history
  2. Make navbar width consistent with splash and generic page containers

    The previous navbar max width looked too small on large screens with
    page content extending beyond the navbar width. This common width should
    really be defined in one place, but that's not trivial as described in
    the TODO comment.
    victorlin committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    5377226 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Make sure all direct children of row are cols

    Future-proofing for Bootstrap v4 change to use flexbox.
    victorlin committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    fb8fc51 View commit details
    Browse the repository at this point in the history
  2. Update to Bootstrap v4

    It's not clear to me where this bootstrap.css file came from, but it
    seems to be roughly a small subset of the bootstrap.css file
    distributed¹ in v3.4.1. This commit replaces it with the
    bootstrap-grid.css file distributed in v4.6.2.
    
    Bootstrap v4 introduced more precise breakpoints and shifted the
    xs/sm/md/lg classes one level down from the previous version.² Usage has
    been adjusted accordingly.
    
    ¹ https://getbootstrap.com/docs/3.4/getting-started/#download
    ² https://getbootstrap.com/docs/4.0/migration/#responsive-utilities
    victorlin committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    5948261 View commit details
    Browse the repository at this point in the history
  3. Adjust footer styles to be consistent with previous appearance before…

    … updating to Bootstrap v4
    
    These seem to be more appropriate. Not sure why these weren't necessary
    before.
    victorlin committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    6177e27 View commit details
    Browse the repository at this point in the history