Update to Bootstrap v4 #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these were set in two places: 1. the modified styled component 2. bootstrap styles on `.container` Move all the relevant bootstrap styles into the modified styled component.
The previous navbar max width looked too small on large screens with page content extending beyond the navbar width. This common width should really be defined in one place, but that's not trivial as described in the TODO comment.
This was referenced Jul 27, 2024
Future-proofing for Bootstrap v4 change to use flexbox.
It's not clear to me where this bootstrap.css file came from, but it seems to be roughly a small subset of the bootstrap.css file distributed¹ in v3.4.1. This commit replaces it with the bootstrap-grid.css file distributed in v4.6.2. Bootstrap v4 introduced more precise breakpoints and shifted the xs/sm/md/lg classes one level down from the previous version.² Usage has been adjusted accordingly. ¹ https://getbootstrap.com/docs/3.4/getting-started/#download ² https://getbootstrap.com/docs/4.0/migration/#responsive-utilities
… updating to Bootstrap v4 These seem to be more appropriate. Not sure why these weren't necessary before.
victorlin
force-pushed
the
victorlin/update-responsive-styling
branch
from
0e09c3b
to
6177e27
Compare
genehack
approved these changes
Jul 29, 2024
joverlee521
approved these changes
Jul 29, 2024
The choice of styling framework is also unclear to me. I've created an issue to continue discussion: #963 |
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
Description of proposed changes
below is from the main commit, but there are additional smaller commits
It's not clear to me where this bootstrap.css file came from, but it seems to be roughly a small subset of the bootstrap.css file distributed¹ in v3.4.1. This commit replaces it with the bootstrap-grid.css file distributed in v4.6.2.
Bootstrap v4 introduced more precise breakpoints and shifted the xs/sm/md/lg classes one level down from the previous version.² Usage has been adjusted accordingly.
¹ https://getbootstrap.com/docs/3.4/getting-started/#download
² https://getbootstrap.com/docs/4.0/migration/#responsive-utilities
Related issue(s)
Checklist
/for changes to footer, nav bar, splash: before, after/sars-cov-2: before, after/contactfor changes to generic-page: before, after