-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm dependencies update to latest (major) #2318
Conversation
0464a4e
to
7e85dca
Compare
# Pull Request ## 🤨 Rationale This Renovate PR #2318 is failing builds because it tries to update eslint to 9.x but javascript-styleguide is only compatible with 8.x. We also don't want Renovate to do major updates of apache arrow in either npm or nuget because it's pinned and needs to stay in sync between npm and nuget so should probably be manually handled. ## 👩💻 Implementation Update Renovate config to exclude those dependencies. I got the names of the dependencies from `packages.json` for npm and `packages.lock.json` for nuget. ## 🧪 Testing After this goes in we can retrigger the Renovate algorithm and see if the major bump excludes these. ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
7e85dca
to
a17d8b0
Compare
@@ -26,6 +26,6 @@ | |||
], | |||
"peerDependencies": { | |||
"cross-env": "^7.0.3", | |||
"rimraf": "^5.0.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says rollup should update but the resolved rollup didn't actually change.
Turns out the rollup-plugin-sourcemaps package we depend on hasn't been updated in years and has a transitive peerdep on rollup 2 so we are stuck on that for the root package resolution. Looks like it's unmaintained: maxdavidson/rollup-plugin-sourcemaps#130
And should maybe switch to https://github.com/2wce/rollup-plugin-sourcemaps2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this package doesn't seem to be used.. https://www.npmjs.com/package/rollup-plugin-sourcemaps2
This isn't causing an actual issue as far as I can tell so just gonna ignore for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also failed the build because the package is missing files the script tried to import.
a17d8b0
to
5ad6b7f
Compare
5ad6b7f
to
b3c763e
Compare
b3c763e
to
51693c5
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@@ -88,7 +88,7 @@ | |||
"@types/d3-scale": "^4.0.2", | |||
"@types/d3-selection": "^3.0.0", | |||
"@types/d3-zoom": "^3.0.0", | |||
"@types/markdown-it": "^13.0.8", | |||
"@types/markdown-it": "^14.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't understand why this is updated again, gonna close the PR and retrigger renovate
# Pull Request ## 🤨 Rationale A follow-up for #2410 and #2408 which were getting in weird states due to dependency updates around rollup. ## 👩💻 Implementation Previously had found that the rollup-plugin-sourcemaps was [causing issues](#2318 (comment)) because it had not been updated in a long time and resulted in a transitive dependency on an old rollup version. This seems to mess with rennovate updates. - Updated to [rollup-plugin-sourcemaps2](https://github.com/2wce/rollup-plugin-sourcemaps2) which now seems to be [used in at least a few projects](https://www.npmjs.com/package/rollup-plugin-sourcemaps2) - Updated other dependencies that were pending - Leveraged a new flag added to concurrently that causes the build logs to align nicer by making prefixes the same width. Also has a bug fix that handles stray new lines once in a while. - Rebuilt the lockfile ## 🧪 Testing - Verified manually that the bundled minified builds have working source maps - Rely on CI for rest of the updates - Trigger full storybook build ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
This PR contains the following updates:
^25.0.7
->^26.0.0
18.19.42
->20.14.14
^10.3.10
->^11.0.0
^5.0.5
->^6.0.0
2.79.1
->4.19.2
Release Notes
rollup/plugins (@rollup/plugin-commonjs)
v26.0.1
2024-06-05
Bugfixes
04a15b5
)v26.0.0
2024-06-05
Breaking Changes
isaacs/node-glob (glob)
v11.0.0
Compare Source
isaacs/rimraf (rimraf)
v6.0.1
Compare Source
v6.0.0
Compare Source
v5.0.10
Compare Source
v5.0.9
Compare Source
v5.0.8
Compare Source
v5.0.7
Compare Source
v5.0.6
Compare Source
v5.0.5
Compare Source
v5.0.4
Compare Source
v5.0.3
Compare Source
v5.0.2
Compare Source
v5.0.1
Compare Source
v5.0.0
Compare Source
v4.4.1
Compare Source
v4.4.0
Compare Source
v4.3.1
Compare Source
v4.3.0
Compare Source
v4.2.0
Compare Source
v4.1.4
Compare Source
v4.1.3
Compare Source
v4.1.2
Compare Source
v4.1.1
Compare Source
v4.1.0
Compare Source
v4.0.7
Compare Source
v4.0.6
Compare Source
v4.0.5
Compare Source
v4.0.4
Compare Source
v4.0.3
Compare Source
v4.0.2
Compare Source
v4.0.1
Compare Source
v4.0.0
Compare Source
v3.0.2
Compare Source
v3.0.1
Compare Source
v3.0.0
Compare Source
rollup/rollup (rollup)
v4.19.2
Compare Source
2024-08-01
Bug Fixes
Pull Requests
v4.19.1
Compare Source
2024-07-27
Bug Fixes
Pull Requests
v4.19.0
Compare Source
2024-07-20
Features
Bug Fixes
Pull Requests
v4.18.1
Compare Source
2024-07-08
Bug Fixes
Pull Requests
%
if URI malformed (@baseballyama, @lukastaegert)v4.18.0
Compare Source
2024-05-22
Features
Pull Requests
v4.17.2
Compare Source
2024-04-30
Bug Fixes
Pull Requests
v4.17.1
Compare Source
2024-04-29
Bug Fixes
Pull Requests
v4.17.0
Compare Source
2024-04-27
Features
Bug Fixes
Pull Requests
v4.16.4
Compare Source
2024-04-23
Bug Fixes
Pull Requests
v4.16.3
Compare Source
2024-04-23
Bug Fixes
Pull Requests
v4.16.2
Compare Source
2024-04-22
Bug Fixes
Pull Requests
v4.16.1
Compare Source
2024-04-21
Bug Fixes
Pull Requests
v4.16.0
Compare Source
2024-04-21
Features
Pull Requests
v4.15.0
Compare Source
2024-04-20
Features
Pull Requests
v4.14.3
Compare Source
2024-04-15
Bug Fixes
Pull Requests
v4.14.2
Compare Source
2024-04-12
Bug Fixes
Pull Requests
v4.14.1
Compare Source
2024-04-07
Bug Fixes
Pull Requests
v4.14.0
Compare Source
2024-04-03
Features
Pull Requests
@shikiji/vitepress-twoslash
(@sapphi-red)v4.13.2
Compare Source
2024-03-28
Bug Fixes
Pull Requests
v4.13.1
Compare Source
2024-03-27
Bug Fixes
Pull Requests
v4.13.0
Compare Source
2024-03-12
Features
Pull Requests
v4.12.1
Compare Source
2024-03-06
Bug Fixes
Pull Requests
getRollupEror
togetRollupError
(@MrRefactoring)import.meta.ROLLUP_FILE_URL_referenceId
correctly (@sapphi-red)v4.12.0
Compare Source
2024-02-16
Features
Pull Requests
v4.11.0
Compare Source
2024-02-15
Features
output.reexportProtoFromExternal
option to disable special code for handling__proto__
reexports (#5380)Bug Fixes
const
variables (#5388)Pull Requests
__proto__
for compatibility with CJS Transpiler Re-exports (@TrickyPi)v4.10.0
Compare Source
2024-02-10
Features
output.hashCharacters
option (#5371)Bug Fixes
Pull Requests
v4.9.6
Compare Source
2024-01-21
Bug Fixes
Pull Requests
v4.9.5
Compare Source
2024-01-12
Bug Fixes
Pull Requests
v4.9.4
Compare Source
2024-01-06
Bug Fixes
Pull Requests
v4.9.3
Compare Source
2024-01-05
Bug Fixes
__proto__
as export/import name (#5313)Pull Requests
v4.9.2
Compare Source
2023-12-30
Bug Fixes
Pull Requests
v4.9.1
Compare Source
2023-12-17
Bug Fixes
Pull Requests
v4.9.0
Compare Source
2023-12-13
Features
Pull Requests
v4.8.0
Compare Source
2023-12-11
Features
experimentalMinChunkSize
to take already loaded modules from dynamic imports into account (#5294)Pull Requests
v4.7.0
Compare Source
2023-12-08
Features
Bug Fixes
Pull Requests
v4.6.1
Compare Source
2023-11-30
Bug Fixes
var
several times was considered a conflict (#5276)Pull Requests
v4.6.0
Compare Source
2023-11-26
Features
this.addWatchFile
in all plugin hooks (#5270)Bug Fixes
npm
issue (#5267)this
context inthis.addWatchFile
so it does not need to be bound when passed around (#5270)Pull Requests
v4.5.2
Compare Source
2023-11-24
Bug Fixes
Pull Requests
v4.5.1
Compare Source
2023-11-21
Bug Fixes
Pull Requests
v4.5.0
Compare Source
2023-11-18
Bug Fixes
Pull Requests
v4.4.1
Compare Source
2023-11-14
Bug Fixes
Pull Requests
v4.4.0
Compare Source
2023-11-12
Features
Bug Fixes
Pull Requests
v4.3.1
Compare Source
2023-11-11
Bug Fixes
Configuration
📅 Schedule: Branch creation - "monthly" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.