Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Apache Arrow and eslint from Renovate major updates #2321

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

jattasNI
Copy link
Contributor

@jattasNI jattasNI commented Aug 1, 2024

Pull Request

🤨 Rationale

This Renovate PR #2318 is failing builds because it tries to update eslint to 9.x but javascript-styleguide is only compatible with 8.x.

We also don't want Renovate to do major updates of apache arrow in either npm or nuget because it's pinned and needs to stay in sync between npm and nuget so should probably be manually handled.

👩‍💻 Implementation

Update Renovate config to exclude those dependencies. I got the names of the dependencies from packages.json for npm and packages.lock.json for nuget.

🧪 Testing

After this goes in we can retrigger the Renovate algorithm and see if the major bump excludes these.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI jattasNI marked this pull request as ready for review August 1, 2024 20:36
@jattasNI jattasNI requested a review from rajsite as a code owner August 1, 2024 20:36
@rajsite rajsite merged commit 186667b into main Aug 1, 2024
13 checks passed
@rajsite rajsite deleted the renovate-opt-out-deps branch August 1, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants