-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: containerd configuration for mirror registry #292
Conversation
Still running manual test with ECR registry mirror. Once the test completed, I will turn the draft PR to Ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the tests!
Tested that mirror configuration is created on AWS VMS.
The cluster partially came up, CNI pods were not starting. Another alternative is to create cluster in airgap environment with ECR mirror. however it will require a lot more additional setup manually which we are planning to perform in konvoy e2e test for cluser class anyways. |
What happens if multiple clusters are marked as mirror? I wonder if the config should look more like:
|
...ndlers/generic/mutation/imageregistries/credentials/credential_provider_config_files_test.go
Outdated
Show resolved
Hide resolved
...ndlers/generic/mutation/imageregistries/credentials/credential_provider_config_files_test.go
Outdated
Show resolved
Hide resolved
...ndlers/generic/mutation/imageregistries/credentials/credential_provider_config_files_test.go
Outdated
Show resolved
Hide resolved
Please review and merge #293 and then rebase this PR. |
1665acf
to
d54a86e
Compare
We did considered this during our discussions. IMHO
We have a google doc with all suggested options for the schema. I will start a thread in slack to discuss it. |
Created stacked PR #296 to fix flakey unit tests. blocking this PR until its merged. |
f143220
to
4dd5b1f
Compare
2daf3e1
to
2ebf893
Compare
Schema changed a lot. please review again.
2ebf893
to
00fdf5e
Compare
pkg/handlers/generic/mutation/imageregistries/credentials/inject.go
Outdated
Show resolved
Hide resolved
6e97e3e
to
f38fafb
Compare
b640c88
to
e6aeebe
Compare
e6aeebe
to
e4881ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed changes from comments, thanks for this PR @supershal!
Thank you @jimmidyson for the final changes. |
🤖 I have created a release *beep* *boop* --- ## 0.3.0 (2024-02-07) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: starts additional sec groups by @faiq in #252 * feat: add control-plane load balancer scheme patch by @dkoshkin in #228 * feat: Pull in CAAPH APIs by @jimmidyson in #282 * feat: Use latest dynamic credential provider and v1 kubelet API by @jimmidyson in #293 * feat: Add ClusterResourceSet strategy for CNI installation by @jimmidyson in #288 * feat: Use CAAPH to deploy Calico on workload clusters by @jimmidyson in #283 * feat: containerd configuration for mirror registry by @supershal in #292 * feat: introduce a Go module for /api by @dkoshkin in #331 ### Fixes 🔧 * fix: Stable EBS CSI manifests by @jimmidyson in #270 * fix: Ensure registry credentials are namespace local to Cluster by @jimmidyson in #332 ### Other Changes * build: Upgrade devbox tools by @jimmidyson in #271 * ci: Update release please configuration for v4 action by @jimmidyson in #274 * build: Add release conventional commut type for release PRs by @jimmidyson in #276 * docs: Add intro page to user docs by @jimmidyson in #280 * build: Use ko for building OCI image by @jimmidyson in #281 * build: Add files for clusterctl compatibility by @jimmidyson in #284 * build: local development in macOS(and Linux) arm64/amd64 using local colima instance by @supershal in #285 * build: Lint for missed errors in tests too by @jimmidyson in #287 * build: Remove unused upx makefile stuff by @jimmidyson in #291 * docs: Fix indentation of AWS secret example by @jimmidyson in #294 * build: Add k8s 1.28 KinD for testing by default by @jimmidyson in #295 * build: Add devbox update scheduled job by @jimmidyson in #310 * build(main): Latest devbox update (2024-01-22) by @github-actions in #315 * ci: Group k8s mod updates for dependabot by @jimmidyson in #316 * build(main): Latest devbox update (2024-01-24) by @d2iq-labs-actions-pr-bot in #320 * build(main): Latest devbox update (2024-02-05) by @d2iq-labs-actions-pr-bot in #326 * docs: fix cluster name in README by @dkoshkin in #330 * ci: Consistent bash defaults in workflows by @jimmidyson in #336 * ci: Tag api module on release by @jimmidyson in #335 ## New Contributors * @d2iq-labs-actions-pr-bot made their first contribution in #320 **Full Changelog**: v0.2.0...v0.3.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closes: #203
✔️ Create containerd mirror configuration for a registry
❌ Create Dynamic Credentials Provider configuration to use static mirror credentials
❌ Update Dynamic Credentials Provider configuration to use mirror credentials only with
MirrorCredentialOnly
strategy✔️ Unit tests to check the generated kubeadm files
✔️ Updated documentation for global mirror
Future PRs:
Following Changes were making the current PR long and complicate to follow. I think we can integrate with konvoy using current changes in the PR.
MirrorCredentialOnly
strategy