chore: update to Physics 10.0.0

[vishwa2710]

Summary by CodeRabbit

• New Features

  • Updated dependencies to the latest major versions for improved functionality and compatibility.
  • Enhanced development environment setup in Docker for better usability.

• Bug Fixes

  • Improved error handling and validation in the Propagator class tests for more robust performance.

• Tests

  • Expanded test coverage for the Propagator class, ensuring accurate handling of dynamics and maneuvers.

[coderabbitai]

Walkthrough

The changes primarily involve updates to version requirements across multiple files related to the OpenSpaceToolkitAstrodynamics project. The CMakeLists.txt and bindings/python/requirements.txt files have been modified to reflect a shift from version 9.x.y to 10.x.y for the Open Space Toolkit Physics dependency. Additionally, the Dockerfile has been updated to enhance the development environment, including changes to the major version of the physics toolkit and the addition of new dependencies. Lastly, the test file for the Propagator class has undergone modifications to improve const-correctness and error handling in the associated tests.

Changes

File	Change Summary
CMakeLists.txt	Updated FIND_PACKAGE line for OpenSpaceToolkitPhysics from version 9.x.y to 10.x.y.
bindings/python/requirements.txt	Updated open-space-toolkit-physics version from ~=9.2 to ~=10.0.
docker/development/Dockerfile	Updated OSTK_PHYSICS_MAJOR from "9" to "10"; added commands for fetching latest patch versions and additional libraries; set up a non-root user environment.
test/OpenSpaceToolkit/Astrodynamics/Trajectory/Propagator.test.cpp	Changed celestials array type to enforce const-correctness; expanded tests for dynamics, error handling, state calculations, and maneuver handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CMake
    participant Docker
    participant Test

    User->>CMake: Update version for OpenSpaceToolkitPhysics
    CMake->>User: Version updated to 10.x.y

    User->>Docker: Update Dockerfile for environment
    Docker->>User: Environment updated with new dependencies

    User->>Test: Enhance Propagator tests
    Test->>User: Tests updated for const-correctness and error handling

Loading

🐰 In the garden where changes bloom,
A toolkit grows, dispelling gloom.
With physics now in version ten,
Our tests are strong, we'll build again!
So hop along, let’s code with glee,
For every change brings joy to me! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 57f7d7c and ccbfcef.

📒 Files selected for processing (4)

• CMakeLists.txt (1 hunks)
• bindings/python/requirements.txt (1 hunks)
• docker/development/Dockerfile (1 hunks)
• test/OpenSpaceToolkit/Astrodynamics/Trajectory/Propagator.test.cpp (1 hunks)

🧰 Additional context used

🔇 Additional comments (5)

bindings/python/requirements.txt (1)

6-6: Approved: Version update for open-space-toolkit-physics

The update from ~=9.2 to ~=10.0 for open-space-toolkit-physics aligns with the PR objective of updating to Physics 10.0.0. This change allows for compatible release updates within the 10.x.x series.

However, please note:

1. Major version updates often introduce breaking changes. Ensure that your codebase is compatible with version 10.0.0 and thoroughly test all functionality that depends on this library.

2. Verify that other dependencies in the project are compatible with this new version of open-space-toolkit-physics.

To help verify the impact of this change, you can run the following script:

This script will help identify areas of the codebase that might need attention due to the version update.

✅ Verification successful

Verified: No Codebase Impact from open-space-toolkit-physics Update

The update from ~=9.2 to ~=10.0 for open-space-toolkit-physics has been verified. The only reference to this library is in the documentation (docs/conf.py), and there are no direct imports or usages in the source code. Additionally, CMakeLists.txt correctly specifies version 10, aligning with the PR.

No further action is required regarding compatibility or codebase adjustments.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for usage of open-space-toolkit-physics in the codebase

echo "Searching for imports or usage of open-space-toolkit-physics:"
rg --type cpp --type python "open-space-toolkit-physics" -g '!{requirements.txt,CMakeLists.txt}'

echo "Checking CMakeLists.txt for OpenSpaceToolkitPhysics version:"
rg "OpenSpaceToolkitPhysics" CMakeLists.txt

Length of output: 709

---

Script:

#!/bin/bash
# Description: Check for usage of open-space-toolkit-physics in the codebase with correct file types

echo "Searching for imports or usage of open-space-toolkit-physics in Python and C++ files:"
rg "open-space-toolkit-physics" --glob "*.py" --glob "*.cpp" --glob "*.hpp" --glob "*.h" -g '!{requirements.txt,CMakeLists.txt}'

echo "Checking CMakeLists.txt for OpenSpaceToolkitPhysics version:"
rg "OpenSpaceToolkitPhysics" CMakeLists.txt

Length of output: 862

CMakeLists.txt (2)

343-345: Approved: Update to OpenSpaceToolkitPhysics 10.x.y

The update to OpenSpaceToolkitPhysics version 10.x.y has been implemented correctly in the CMakeLists.txt file. This change aligns with the PR objectives to update to Physics 10.0.0.

To ensure compatibility with the new version:

1. Verify that the project builds successfully with the new dependency version.
2. Run the project's test suite to catch any potential breaking changes.
3. Review the changelog or release notes of OpenSpaceToolkitPhysics 10.x.y for any breaking changes that might affect this project.

Consider updating the project's documentation (e.g., README.md, dependency lists) to reflect this new version requirement.

---

Line range hint 1-1000: Verify project-wide compatibility with OpenSpaceToolkitPhysics 10.x.y

While the CMakeLists.txt update is correct, updating to a new major version of OpenSpaceToolkitPhysics may have broader implications for the project.

Please ensure the following:

1. Review all uses of OpenSpaceToolkitPhysics throughout the project for compatibility with version 10.x.y.
2. Update any code that may be affected by breaking changes introduced in the new version.
3. Verify that all tests pass with the new dependency version.

If you need help identifying and resolving any compatibility issues with OpenSpaceToolkitPhysics 10.x.y, please let me know, and I can assist in creating a detailed migration plan or opening relevant GitHub issues.

docker/development/Dockerfile (1)

151-151: LGTM

Updating OSTK_PHYSICS_MAJOR to "10" correctly updates the major version for Open Space Toolkit Physics in the Dockerfile.

test/OpenSpaceToolkit/Astrodynamics/Trajectory/Propagator.test.cpp (1)

1242-1242: Verify compatibility of celestials type change to Array<Shared<const Object>>.

Changing the type of celestials to Array<Shared<const Object>> enforces const-correctness, which is beneficial for preventing unintended modifications to celestial objects. However, we need to ensure that all usages of celestials throughout the codebase are compatible with this change. Any functions or methods that modify elements within celestials will now cause compilation errors.

Run the following script to identify any code that attempts to modify elements of celestials:

This script looks for any assignment operations to members of the objects within celestials. Review any matches and update the code to handle Shared<const Object> appropriately, ensuring that no modifications are attempted on const objects.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (57f7d7c) to head (ccbfcef).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files          85       85           
  Lines        8618     8618           
=======================================
  Hits         7836     7836           
  Misses        782      782           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.