Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace pkg_resources with importlib.resources" #36208

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

jesperhodge
Copy link
Member

@jesperhodge jesperhodge commented Feb 3, 2025

Before merge:

  • This needs to be tested in a stage/prod like environment
  • Needs some assessment of the risks involved in deploying it
  • At minimum this needs the edx-platform pipeline on 2U's side paused and a smoke test in stage

Description:

This PR reverts a change which appears to have caused the unit pages of different courses not to work on stage and prod. The bug started right after the change was deployed (January 23) and relates to code that was modified.

Context:

https://openedx.slack.com/archives/C0497NQCLBT/p1738607786863749

Internal TNL Links:

Steps to reproduce bug (on stage or prod):

  • Not reproducible locally because local asset urls are different anyway
  • Go to a stage or prod environment
  • Create a drag-and-drop component (or poll, survey, or anything not core)
  • Load the unit page (shows loading spinner)
  • Try to edit the drag-and-drop component (cannot edit or save)
  • Add a problem block after the failed component
  • That problem block will also not load

Causes:

  • CMS calls to /static/studio/xblock/resources/... produce 404s
  • The PR to revert modifies code that relates to providing / accessing these xblock resources

Reverts #36044

@schenedx schenedx force-pushed the revert-36044-pkg_resources-depr branch from 88b95e1 to 8bdedda Compare February 3, 2025 19:48
@jesperhodge
Copy link
Member Author

Currently testing this locally.

@jesperhodge
Copy link
Member Author

Tested locally. Don't see any immediate problem so we can proceed to next step (SRE risk assessment).

@jesperhodge
Copy link
Member Author

I changed this to draft so it doesn't get merged by accident.
We do not deem this safe enough to deploy at this time.

@kdmccormick kdmccormick marked this pull request as ready for review February 4, 2025 21:41
@schenedx schenedx merged commit 1f43d17 into master Feb 5, 2025
49 checks passed
@schenedx schenedx deleted the revert-36044-pkg_resources-depr branch February 5, 2025 13:51
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants