Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable disabled tests and stop using deploymentconfig #1645

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Enable disabled tests and stop using deploymentconfig #1645

merged 1 commit into from
Feb 14, 2024

Conversation

fedinskiy
Copy link
Contributor

Summary

https://issues.redhat.com/browse/QQE-401
https://issues.redhat.com/browse/QQE-463

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy self-assigned this Feb 8, 2024
@gtroitsk gtroitsk mentioned this pull request Feb 10, 2024
Merged
9 tasks
@fedinskiy
Copy link
Contributor Author

run tests

michalvavrik
michalvavrik reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

...ient/src/test/java/io/quarkus/ts/infinispan/client/OperatorOpenShiftInfinispanObjectsIT.java Outdated Show resolved Hide resolved
config/src/test/java/io/quarkus/ts/configmap/api/server/OpenShiftFailOnMissingConfigIT.java Outdated Show resolved Hide resolved
@fedinskiy fedinskiy force-pushed the feature/enable-disabled-q1-24 branch 2 times, most recently from cd9ab1f to d012221 Compare February 13, 2024 10:45
michalvavrik
michalvavrik approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still a draft, but I can't see any reason why I should approve - LGTM

@fedinskiy fedinskiy marked this pull request as ready for review February 13, 2024 14:34
@fedinskiy
Copy link
Contributor Author

run tests

1 similar comment
@fedinskiy
Copy link
Contributor Author

run tests

@michalvavrik
Copy link
Member

@fedinskiy ServerlessExtensionOpenShiftFunqyKnEventsIT failed over Terminating due to java.lang.OutOfMemoryError: GC overhead limit exceeded. This PR enables it, can you at least check what is going on? I think if it keeps failing often it would be a problem.

Side note: it would be interesting to clean resources on rerun, but I don't think it will be easy.

@michalvavrik
Copy link
Member

Anyway, I think we can get it in as it also bumps FW and fixes OCP issues. You can look at it separately if you want and if it fails often we can disable it.

@fedinskiy
Copy link
Contributor Author

@michalvavrik this failure is due to quarkusio/quarkus#37142. I disabled the test in Native, but at least we have JVM mode working. Let's see, whether CI likes that.

run tests

@fedinskiy fedinskiy merged commit f36f28f into main Feb 14, 2024
9 checks passed
@michalvavrik michalvavrik deleted the feature/enable-disabled-q1-24 branch February 14, 2024 16:05
@fedinskiy fedinskiy mentioned this pull request Feb 16, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees

@fedinskiy fedinskiy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @michalvavrik