Bugfix: Where 2030 capacity bounds are distributed to regions by GDP share, use 2025 GDP instead of 2030 GDP to avoid potential infes in non-SSP2 policy runs #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 16, 2024 13:22
… use GDP 2020 share instead of later years as GDP can be different across SSPs leading to infes
…DP now as this is the last year where GDP is the same across all scenarios
laurinks
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Looks good to me. GDP is indeed equal for all SSPs in 2025 so this option should be safe. Thanks, @fschreyer, for fixing this quickly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Where global capacity bounds are distributed to regions by GDP share, use GDP 2025 share instead of later years as GDP can be different across SSPs leading to infes.
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
FAIL 0in the output ofmake test)Further information (optional):