Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gmock CMP0115 (backport #1830) #1848

Closed
wants to merge 1 commit into from
Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2024

Fixes

--- stderr: controller_manager                                           
CMake Warning (dev) at /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock_executable.cmake:50 (add_executable):
  Policy CMP0115 is not set: Source file extensions must be explicit.  Run
  "cmake --help-policy CMP0115" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  File:

    /workspaces/ros2_rolling_ws/src/ros2_control/controller_manager/test/test_hardware_spawner.cpp
Call Stack (most recent call first):
  /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock_executable.cmake:37 (_ament_add_gmock_executable)
  /opt/ros/rolling/share/ament_cmake_gmock/cmake/ament_add_gmock.cmake:65 (ament_add_gmock_executable)
  CMakeLists.txt:197 (ament_add_gmock)
This warning is for project developers.  Use -Wno-dev to suppress it.

This is an automatic backport of pull request #1830 done by [Mergify](https://mergify.com).

(cherry picked from commit 434f7f5)

# Conflicts:
#	controller_manager/CMakeLists.txt
@mergify mergify bot added the conflicts label Nov 4, 2024
Copy link
Contributor Author

mergify bot commented Nov 4, 2024

Cherry-pick of 434f7f5 has failed:

On branch mergify/bp/humble/pr-1830
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 434f7f5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@christophfroehlich
Copy link
Contributor

needs #1827 first

@christophfroehlich christophfroehlich marked this pull request as draft November 4, 2024 19:22
@christophfroehlich
Copy link
Contributor

already included in #1827

@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1830 branch November 10, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant