Fix the missing bcolors.ENDC in hardware_spawner log prints
#1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bmagyar,
christophfroehlich,
DasRoteSkelett,
livanov93,
mamueluth and
moriarty
saikishor
force-pushed
the
fix/hardware_spawner/log_coloring
branch
from
44e294b
to
db8b47b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1870 +/- ##
=======================================
Coverage 87.98% 87.98%
=======================================
Files 121 121
Lines 12413 12413
Branches 1109 1109
=======================================
+ Hits 10921 10922 +1
Misses 1085 1085
+ Partials 407 406 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Nov 9, 2024
christophfroehlich
merged commit ec70ae1
into
ros-controls:master
17 of 19 checks passed
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 9, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 9, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 10, 2024
* Fix Hardware spawner and add tests for it (#1759) * Tests for hardware spawner. * Fully support spawning a list of hardware components * Use python3 coverage instead of ros2 run in tests * Actually check component's state after changing it * Update hardware_spawner's user documentation --------- Co-authored-by: Dr. Denis Štogl <denis@stoglrobotics.de> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> (cherry picked from commit 5dbd6d5) # Conflicts: # controller_manager/CMakeLists.txt * Fix conflict * Fix the missing bcolors.ENDC in hardware_spawner log prints (#1870) * Choose pass_urdf_as_parameter as false --------- Co-authored-by: Felix Exner (fexner) <exner@fzi.de> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
christophfroehlich
added a commit
that referenced
this pull request
Nov 10, 2024
* Fix Hardware spawner and add tests for it (#1759) * Tests for hardware spawner. * Fully support spawning a list of hardware components * Use python3 coverage instead of ros2 run in tests * Actually check component's state after changing it * Update hardware_spawner's user documentation --------- Co-authored-by: Dr. Denis Štogl <denis@stoglrobotics.de> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> (cherry picked from commit 5dbd6d5) # Conflicts: # controller_manager/CMakeLists.txt * Fix conflicts * FIx missing lines * Fix the missing bcolors.ENDC in hardware_spawner log prints (#1870) * Fix pre-commit * Fix the API of the tests and the CMakeLists.txt * Apply target properties as other tests --------- Co-authored-by: Felix Exner (fexner) <exner@fzi.de> Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running some tests, I realized that the
bcolors.ENDCis missing in couple of logging statements in hardware spawner and this is causing the logs to continue to stay in that color.Previously:
With the fix proposed in this PR:
