Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mock_hardware to diffbot and update docs for all usages #357

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Adding mock_hardware to diffbot and update docs for all usages #357

merged 3 commits into from
Oct 3, 2023

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Sep 7, 2023 •
edited
Loading

I implemented the mock_hardware for the diffbot to test ros-controls/ros2_control#1028
It simply works ;)

This PR closes #254.

@christophfroehlich christophfroehlich mentioned this pull request Sep 7, 2023
Merged
@christophfroehlich christophfroehlich marked this pull request as ready for review October 3, 2023 18:06
@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2023 •
edited
Loading

backport humble

✅ Backports have been created

saikishor
saikishor approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. Thanks for the nice update.

olivier-stasse
olivier-stasse approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested.
Thanks for the PR !

@christophfroehlich christophfroehlich merged commit 7a5cf6d into ros-controls:master Oct 3, 2023
18 of 19 checks passed
@christophfroehlich christophfroehlich deleted the diffbot_mock branch October 3, 2023 21:23
mergify bot pushed a commit that referenced this pull request Oct 3, 2023
@christophfroehlich @mergify
Adding mock_hardware to diffbot and update docs for all usages (#357)
c35c983 
* Add mock_hardware to diffbot

* Fix position_state_following_offset and description

(cherry picked from commit 7a5cf6d)
@mergify mergify bot mentioned this pull request Oct 3, 2023
Merged
christophfroehlich added a commit that referenced this pull request Oct 9, 2023
@mergify @christophfroehlich
Adding mock_hardware to diffbot and update docs for all usages (#357) (…
665d23b 
…#371)

* Add mock_hardware to diffbot

* Fix position_state_following_offset and description

(cherry picked from commit 7a5cf6d)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@olivier-stasse olivier-stasse olivier-stasse approved these changes

@destogl destogl Awaiting requested review from destogl

@ARK3r ARK3r Awaiting requested review from ARK3r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Describe mock_hardware
3 participants
@christophfroehlich @olivier-stasse @saikishor