-
Notifications
You must be signed in to change notification settings - Fork 2
Add controller manager introspection topic system #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 61.44% 68.85% +7.40%
==========================================
Files 3 5 +2
Lines 249 366 +117
Branches 42 52 +10
==========================================
+ Hits 153 252 +99
- Misses 75 86 +11
- Partials 21 28 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
"~/values", rclcpp::SensorDataQoS(), | ||
[this](const pal_statistics_msgs::msg::StatisticsValues::SharedPtr pal_values) { | ||
latest_pal_values_ = *pal_values; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a warning if nothing is publishing on the configured topics? That or add a throttled print when // no data received yet
in read().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my case it was obvious because no joint_states/tf was published then. But sure, a throttled warning does not hurt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with b2ff118
#include <rclcpp_lifecycle/state.hpp> | ||
#include <ros2_control_test_assets/descriptions.hpp> | ||
|
||
TEST(TestTopicBasedSystem, load_topic_based_system_2dof) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding a test that publishes on the topics this system is listening to and verifying the state matches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be great :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Maybe have some data in there that is should nicely ignore 😄.
if (joint_state_interfaces_.find(name) != joint_state_interfaces_.end() ||
sensor_state_interfaces_.find(name) != sensor_state_interfaces_.end() ||
gpio_state_interfaces_.find(name) != gpio_state_interfaces_.end() ||
unlisted_state_interfaces_.find(name) != unlisted_state_interfaces_.end())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some tests with 002ec8a
Co-authored-by: Marq Rasmussen <marq.razz@gmail.com>
This is useful to replay bags and inject state interfaces from a hardware component into the ros2_control stack.
I'm open for any name suggestions ;)