Skip to content

Conversation

christophfroehlich
Copy link
Contributor

In file included from /workspaces/ros2_rolling_ws/src/topic_based_hardware_interfaces/joint_state_topic_hardware_interface/src/joint_state_topic_hardware_interface.cpp:25:
/workspaces/ros2_rolling_ws/src/topic_based_hardware_interfaces/joint_state_topic_hardware_interface/include/joint_state_topic_hardware_interface/joint_state_topic_hardware_interface.hpp:71:36: error: non-static data member 'joint_states_' of 'JointStateTopicSystem' shadows member inherited from type 'HardwareComponentInterface' [-Werror,-Wshadow-field]
   71 |   std::vector<std::vector<double>> joint_states_;
      |                                    ^
/workspaces/ros2_rolling_ws/install/hardware_interface/include/hardware_interface/hardware_interface/hardware_component_interface.hpp:788:42: note: declared here
  788 |   std::vector<StateInterface::SharedPtr> joint_states_;
      |                                          ^

Fixes #35, #36

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.62%. Comparing base (c179773) to head (ddadfb9).

Files with missing lines Patch % Lines
...rface/src/joint_state_topic_hardware_interface.cpp 22.22% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   38.62%   38.62%           
=======================================
  Files           2        2           
  Lines         145      145           
  Branches       34       34           
=======================================
  Hits           56       56           
  Misses         80       80           
  Partials        9        9           
Flag Coverage Δ
unittests 38.62% <22.22%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rface/src/joint_state_topic_hardware_interface.cpp 32.81% <22.22%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up!

@christophfroehlich christophfroehlich merged commit dd0809e into main Oct 3, 2025
30 checks passed
@christophfroehlich christophfroehlich deleted the fix/compilererrors branch October 3, 2025 16:07
@christophfroehlich
Copy link
Contributor Author

oh, I forgot that PR. The last release will fail on the buildfarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI build job jazzy/testing failed! CI build job kilted/testing failed!

3 participants