User interface for managing mismatched liquid calibration COMs

[ogeesan]

Current Behaviour:
Liquid calibration files specify which COM port they were last used with.
During startup, a Command Window warning is issued if the currently booting Bpod's COM does not match the COM in the liquid calibration file that was loaded.

Desired Behaviour:
Instead of a warning into the Command Window, detection of the COM discrepancy should raise a UI that allows user to either ignore the discrepancy (with the intent of recalibrating the system) or:

• For single machine setups: over-write the COM field of the existing liquid calibration file with the current COM.
• For multi machine setups: "import" a calibration file from a different machine into the current machine's Config/.

This PR implements the desired behaviour.

[sanworks]

Hi George,

Is it necessary to convert Linux COM ports to windows style? I checked with git grep and it looks like getCurrentCOM is called in many places throughout BpodLib, and its output is exposed to user user (e.g. saving the COM port with settings or calibration data). This would be confusing to users on Linux, who only know the machine by its Linux port name.

Thanks!
Josh

[ogeesan]

Hey Josh! No it isn't necessary to convert the COM. The original reason that I made it convert everything to "COM" is that I thought it would be easier to search for machine identities. This actually isn't true, so there's no good reason to keep it that way.

It's simple change for this, however the tests have to be updated to handle the Linux case. I'll have this done within a day or two.

[sanworks]

Hi George,

I merged this, but then discovered a pair of bugs:

• In a clean setup where /Bpod Local/ does not exist, the default liquid calibration file is copied but a COM port field is not added, so the new handling GUIs are never triggered. This is true for single and multi-setup.

• In a run with the multi-setup, the GUI listed the COM port it claims it couldn't detect (screenshot attached).

Thanks,
Josh