Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix form for resoures #704

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Jul 22, 2024

Story

A dev was unable to edit a resource without receiving an error from the partial. This PR updates the partials to handle resources and dog biscuit records.

Refs

Expected Behavior Before Changes

image

Expected Behavior After Changes

image

@ShanaLMoore ShanaLMoore changed the base branch from main to pull-in-hyku-knapsack July 22, 2024 17:59
@ShanaLMoore ShanaLMoore marked this pull request as ready for review July 22, 2024 18:00
@ShanaLMoore ShanaLMoore marked this pull request as draft July 22, 2024 19:22
@ShanaLMoore ShanaLMoore reopened this Jul 22, 2024
to avoid error: ".yarn-tarball.tgz: no space left on device"

ref: https://assaydepot.slack.com/archives/C0313NK5NMA/p1713461713731049
…cords

fix: Ensure multiple? method is called correctly for new and existing records

- Updated the view logic to check if the instance responds to `multiple?` first.
- If the instance does not respond, then check if the class responds to `multiple?`.
- This ensures the correct method is called for both new and existing records, preventing method undefined errors.
Copy link
Contributor

@laritakr laritakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I had in mind for now... we can move toward eliminating the partials later.

@ShanaLMoore ShanaLMoore marked this pull request as ready for review July 23, 2024 14:42
@ShanaLMoore ShanaLMoore merged commit 5213dbb into pull-in-hyku-knapsack Jul 23, 2024
1 check passed
@ShanaLMoore ShanaLMoore deleted the fix-form-for-resoures branch July 23, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants