feat(starknet_patricia,starknet_committer): stop using custom ContractAddress type

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-02-06T09:47:52Z
• Started at 2025-02-06T11:28:48Z
• Started at 2025-02-06T11:35:21Z
• Started at 2025-02-06T11:42:01Z
• Started at 2025-02-06T11:43:54Z
• Started at 2025-02-06T13:32:17Z
• Started at 2025-02-06T13:42:26Z
• Started at 2025-02-06T14:00:37Z
• Started at 2025-02-06T15:32:26Z
• Started at 2025-02-11T20:37:23Z
• Started at 2025-02-16T14:02:20Z
• Started at 2025-02-16T14:27:16Z
• Started at 2025-02-16T14:35:48Z
• Started at 2025-02-19T09:41:08Z
• Started at 2025-02-19T12:49:56Z
• Started at 2025-02-20T12:12:07Z

[dorimedini-starkware]

• feat(starknet_patricia,starknet_committer): stop using custom CompiledClassHash type #4005
• feat(starknet_patricia,starknet_committer): stop using custom Nonce type #4004
• feat(starknet_patricia,starknet_committer): stop using custom ClassHash type #4003
• feat(starknet_patricia,starknet_committer): stop using custom ContractAddress type #4002 👈 (View in Graphite)
• feat(starknet_patricia,starknet_committer): stop using custom Felt type #4001
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[AvivYossef-starkware]

Reviewed 6 of 19 files at r1, 15 of 15 files at r2.
Reviewable status: 18 of 21 files reviewed, 3 unresolved discussions (waiting on @TzahiTaub)

---

crates/starknet_committer_and_os_cli/Cargo.toml line 32 at r2 (raw file):

serde_repr.workspace = true
starknet-types-core.workspace = true
starknet_api = { workspace = true, features = ["testing"] }

do you use the feature, not in test file?

---

crates/starknet_committer/src/block_committer/input.rs line 18 at r2 (raw file):

pub mod input_test;

pub fn try_from_node_index_for_contract_address(

The starknet_patricia crate can be depended on the starknet_api crate, right?
If so, you can
impl TryFrom<&NodeIndex> for ContractAddress {
Next to NodeIndex deifinition

---

crates/starknet_committer/src/block_committer/input.rs line 34 at r2 (raw file):

}

pub fn from_contract_address_for_node_index(address: &ContractAddress) -> NodeIndex {

the same as above

[dorimedini-starkware]

Reviewable status: 18 of 21 files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware and @TzahiTaub)

---

crates/starknet_committer/src/block_committer/input.rs line 18 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

The starknet_patricia crate can be depended on the starknet_api crate, right?
If so, you can
impl TryFrom<&NodeIndex> for ContractAddress {
Next to NodeIndex deifinition

this means that the starknet_patricia crate will "be aware of specific leaf types", which is something I'd prefer to avoid. WDYT?

---

crates/starknet_committer/src/block_committer/input.rs line 34 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

the same as above

same as above

---

crates/starknet_committer_and_os_cli/Cargo.toml line 32 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

do you use the feature, not in test file?

Done.

[dorimedini-starkware]

Reviewable status: 16 of 21 files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware and @TzahiTaub)

---

crates/starknet_committer/src/block_committer/input.rs line 18 at r2 (raw file):

Previously, dorimedini-starkware wrote…

this means that the starknet_patricia crate will "be aware of specific leaf types", which is something I'd prefer to avoid. WDYT?

starknet_api defines ContractAddress,
starknet_patricia defines NodeIndex,
and starknet_committer defines "ContractAddress as a leaf"

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.963 ms 35.012 ms 35.065 ms]
change: [-4.0458% -2.5288% -1.2089%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
3 (3.00%) low mild
4 (4.00%) high mild
2 (2.00%) high severe

[AvivYossef-starkware]

Reviewed 3 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/starknet_committer/src/block_committer/input.rs line 18 at r2 (raw file):

Previously, dorimedini-starkware wrote…

starknet_api defines ContractAddress,
starknet_patricia defines NodeIndex,
and starknet_committer defines "ContractAddress as a leaf"

mmm, it sounds reasonable to me.

[AvivYossef-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

---

crates/starknet_committer/src/block_committer/input.rs line 18 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

mmm, it sounds reasonable to me.

not sure what you mean. want me to implement TryFrom<&NodeIndex> for ContractAddress in the patricia crate? or does the crate separation sound reasonable to you?

[AvivYossef-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

---

crates/starknet_committer/src/block_committer/input.rs line 18 at r2 (raw file):

Previously, dorimedini-starkware wrote…

not sure what you mean. want me to implement TryFrom<&NodeIndex> for ContractAddress in the patricia crate? or does the crate separation sound reasonable to you?

I'm ok with the crate separation and the current PR