Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_patricia,starknet_committer): stop using custom Nonce type #4004

Open
wants to merge 1 commit into
base: 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type
Choose a base branch
from

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review February 6, 2025 11:27
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 06bb21f to 97dcefa Compare February 6, 2025 11:28
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 24c6121 to 1600d5f Compare February 6, 2025 11:29
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 97dcefa to d39c2d1 Compare February 6, 2025 11:35
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 1600d5f to e9b4681 Compare February 6, 2025 11:35
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from d39c2d1 to 08b5777 Compare February 6, 2025 11:42
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from e9b4681 to 5c5c2af Compare February 6, 2025 11:42
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 08b5777 to a2b7847 Compare February 6, 2025 11:44
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 5c5c2af to 0848939 Compare February 6, 2025 11:44
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from a2b7847 to 2183e53 Compare February 6, 2025 13:32
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 0848939 to 5d0eaaa Compare February 6, 2025 13:32
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 2183e53 to 2f8a423 Compare February 6, 2025 13:42
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 5d0eaaa to d97391c Compare February 6, 2025 13:42
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 2f8a423 to ee5bb49 Compare February 6, 2025 14:00
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from d97391c to d75a24c Compare February 6, 2025 14:00
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from ee5bb49 to d4803a6 Compare February 6, 2025 15:32
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from d75a24c to 6743852 Compare February 6, 2025 15:32
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from d4803a6 to 0acb79d Compare February 6, 2025 15:53
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 6743852 to 513011d Compare February 6, 2025 15:53
Copy link

github-actions bot commented Feb 6, 2025

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.758 ms 34.786 ms 34.817 ms]
change: [-5.2666% -3.7276% -2.3922%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low mild
3 (3.00%) high mild
1 (1.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 0acb79d to 5f13bef Compare February 11, 2025 20:37
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 513011d to 4988bc6 Compare February 11, 2025 20:37
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 5f13bef to 951d74a Compare February 16, 2025 14:02
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 4988bc6 to 87508e2 Compare February 16, 2025 14:02
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 951d74a to f9da98a Compare February 16, 2025 14:27
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 87508e2 to 6b97918 Compare February 16, 2025 14:27
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from f9da98a to a1d410c Compare February 16, 2025 14:35
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 6b97918 to 648324e Compare February 16, 2025 14:36
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.850 ms 34.881 ms 34.915 ms]
change: [-6.6004% -3.9523% -1.9123%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from a1d410c to 50c9ef0 Compare February 19, 2025 09:41
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 648324e to 5221e06 Compare February 19, 2025 09:41
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 50c9ef0 to 1e3413d Compare February 19, 2025 12:50
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 5221e06 to 3aa50bb Compare February 19, 2025 12:50
Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [30.266 ms 30.314 ms 30.364 ms]
change: [-2.6582% -2.4559% -2.2396%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 14 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 1e3413d to a954199 Compare February 20, 2025 12:12
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_nonce_type branch from 3aa50bb to 8600905 Compare February 20, 2025 12:12
Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [30.084 ms 30.119 ms 30.156 ms]
change: [-1.6152% -1.3769% -1.1469%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants