-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_patricia,starknet_committer): stop using custom ClassHash type #4003
base: 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8624d02
to
f14107d
Compare
06bb21f
to
97dcefa
Compare
f14107d
to
c211f84
Compare
97dcefa
to
d39c2d1
Compare
c211f84
to
36ca70a
Compare
d39c2d1
to
08b5777
Compare
36ca70a
to
a325b53
Compare
08b5777
to
a2b7847
Compare
a325b53
to
c7cb0d5
Compare
a2b7847
to
2183e53
Compare
c7cb0d5
to
488241c
Compare
2183e53
to
2f8a423
Compare
488241c
to
a8b53c0
Compare
2f8a423
to
ee5bb49
Compare
a8b53c0
to
fa692c7
Compare
d4803a6
to
0acb79d
Compare
fa692c7
to
1571247
Compare
0acb79d
to
5f13bef
Compare
1571247
to
52a8001
Compare
5f13bef
to
951d74a
Compare
52a8001
to
a013b82
Compare
951d74a
to
f9da98a
Compare
a013b82
to
9619c3c
Compare
f9da98a
to
a1d410c
Compare
Benchmark movements: |
9619c3c
to
788989c
Compare
a1d410c
to
50c9ef0
Compare
788989c
to
90f3bea
Compare
50c9ef0
to
1e3413d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 15 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)
crates/starknet_committer/Cargo.toml
line 23 at r2 (raw file):
[dev-dependencies] starknet_api = { workspace = true, features = ["testing"] }
Do you use the feature not in a test file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @TzahiTaub)
crates/starknet_committer/Cargo.toml
line 23 at r2 (raw file):
Previously, AvivYossef-starkware wrote…
Do you use the feature not in a test file?
this is in dev-dependencies, so only in test files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
90f3bea
to
48e3dca
Compare
1e3413d
to
a954199
Compare
No description provided.