Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_patricia,starknet_committer): stop using custom ClassHash type #4003

Open
wants to merge 1 commit into
base: 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type
Choose a base branch
from

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review February 6, 2025 11:27
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from 8624d02 to f14107d Compare February 6, 2025 11:28
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 06bb21f to 97dcefa Compare February 6, 2025 11:28
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from f14107d to c211f84 Compare February 6, 2025 11:35
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 97dcefa to d39c2d1 Compare February 6, 2025 11:35
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from c211f84 to 36ca70a Compare February 6, 2025 11:42
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from d39c2d1 to 08b5777 Compare February 6, 2025 11:42
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from 36ca70a to a325b53 Compare February 6, 2025 11:43
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 08b5777 to a2b7847 Compare February 6, 2025 11:44
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from a325b53 to c7cb0d5 Compare February 6, 2025 13:32
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from a2b7847 to 2183e53 Compare February 6, 2025 13:32
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from c7cb0d5 to 488241c Compare February 6, 2025 13:42
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 2183e53 to 2f8a423 Compare February 6, 2025 13:42
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from 488241c to a8b53c0 Compare February 6, 2025 14:00
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 2f8a423 to ee5bb49 Compare February 6, 2025 14:00
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from a8b53c0 to fa692c7 Compare February 6, 2025 15:32
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch 2 times, most recently from d4803a6 to 0acb79d Compare February 6, 2025 15:53
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from fa692c7 to 1571247 Compare February 11, 2025 20:37
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 0acb79d to 5f13bef Compare February 11, 2025 20:37
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from 1571247 to 52a8001 Compare February 16, 2025 14:02
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 5f13bef to 951d74a Compare February 16, 2025 14:02
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from 52a8001 to a013b82 Compare February 16, 2025 14:27
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 951d74a to f9da98a Compare February 16, 2025 14:27
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from a013b82 to 9619c3c Compare February 16, 2025 14:35
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from f9da98a to a1d410c Compare February 16, 2025 14:35
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [35.149 ms 35.262 ms 35.420 ms]
change: [-4.2833% -2.6142% -1.1586%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from 9619c3c to 788989c Compare February 19, 2025 09:41
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from a1d410c to 50c9ef0 Compare February 19, 2025 09:41
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from 788989c to 90f3bea Compare February 19, 2025 12:49
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 50c9ef0 to 1e3413d Compare February 19, 2025 12:50
Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 15 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)


crates/starknet_committer/Cargo.toml line 23 at r2 (raw file):

[dev-dependencies]
starknet_api = { workspace = true, features = ["testing"] }

Do you use the feature not in a test file?

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @TzahiTaub)


crates/starknet_committer/Cargo.toml line 23 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

Do you use the feature not in a test file?

this is in dev-dependencies, so only in test files

Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_contractaddress_type branch from 90f3bea to 48e3dca Compare February 20, 2025 12:12
@dorimedini-starkware dorimedini-starkware force-pushed the 02-06-feat_starknet_patricia_starknet_committer_stop_using_custom_classhash_type branch from 1e3413d to a954199 Compare February 20, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants