Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-return for snow simulation #348

Merged
merged 9 commits into from
Aug 28, 2024
Merged

Add multi-return for snow simulation #348

merged 9 commits into from
Aug 28, 2024

Conversation

PawelLiberadzki
Copy link
Contributor

@PawelLiberadzki PawelLiberadzki commented Aug 26, 2024 •
edited
Loading

Description

This PR introduces two things (based on updates to RGL library):

  • new implementation of LiDAR return modes - there are more return modes available and they are independent of laser beam divergence,
  • update to snow simulation for multi-return feature - now snow simulation works correctly with updated return modes and divergence; what is also important, snow simulation, return modes and beam divergence are independent on each other, e.g. user may decide to turn on snow simulation, choose single return mode 'first', and turn off beam divergence - each setup should work correctly.

@PawelLiberadzki
Make updates to multi-return and snow simulation.
bfd689f 
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
@PawelLiberadzki
Remove not used include.
1cd379f 
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
@PawelLiberadzki
Update LiDAR prefabs to new multi-return.
990e6a6 
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
@PawelLiberadzki
Add updated RGL binary.
d1718ae 
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
@PawelLiberadzki
Fix RGL binary.
8c43c11 
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
msz-rai
msz-rai reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@msz-rai msz-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good 👍
I am waiting for docs update to approve it.

Assets/RGLUnityPlugin/Scripts/LidarSensor.cs Outdated Show resolved Hide resolved
@PawelLiberadzki
Change default setting of LiDAR divergence.
361b9aa 
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
@PawelLiberadzki
Update documentation on multi-return.
1ecaab1 
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
msz-rai
msz-rai approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@msz-rai msz-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Assets/RGLUnityPlugin/Scripts/LidarSensor.cs Outdated Show resolved Hide resolved
PawelLiberadzki and others added 2 commits August 28, 2024 09:36
@PawelLiberadzki
Make changes based on review.
d75ba67 
Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
@msz-rai
Update RGL binaries (#351)
c8e38cb 
* Update RGL Linux binary

* Update RGL Windows binary
@PawelLiberadzki PawelLiberadzki merged commit fb338da into feature/rgl-24q3 Aug 28, 2024
1 of 2 checks passed
PiotrMrozik pushed a commit that referenced this pull request Sep 5, 2024
@PawelLiberadzki @msz-rai @PiotrMrozik
Add multi-return for snow simulation (#348)
3079d62 
* Make updates to multi-return and snow simulation.

* Remove not used include.

* Update LiDAR prefabs to new multi-return.

* Add updated RGL binary.

* Fix RGL binary.

* Change default setting of LiDAR divergence.

* Update documentation on multi-return.

* Make changes based on review.

* Update RGL binaries (#351)

* Update RGL Linux binary

* Update RGL Windows binary

---------

Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
Co-authored-by: Mateusz Szczygielski <112629916+msz-rai@users.noreply.github.com>
PiotrMrozik pushed a commit that referenced this pull request Sep 16, 2024
@PawelLiberadzki @msz-rai @PiotrMrozik
Add multi-return for snow simulation (#348)
e9f331b 
* Make updates to multi-return and snow simulation.

* Remove not used include.

* Update LiDAR prefabs to new multi-return.

* Add updated RGL binary.

* Fix RGL binary.

* Change default setting of LiDAR divergence.

* Update documentation on multi-return.

* Make changes based on review.

* Update RGL binaries (#351)

* Update RGL Linux binary

* Update RGL Windows binary

---------

Signed-off-by: Paweł Liberadzki <pawel.liberadzki@robotec.ai>
Co-authored-by: Mateusz Szczygielski <112629916+msz-rai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msz-rai msz-rai msz-rai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PawelLiberadzki @msz-rai