Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unavailable bounties #11

Closed
rndquu opened this issue Sep 1, 2023 · 37 comments · Fixed by ubiquity/devpool-directory#1102
Closed

Hide unavailable bounties #11

rndquu opened this issue Sep 1, 2023 · 37 comments · Fixed by ubiquity/devpool-directory#1102

Comments

@rndquu
Copy link
Member

rndquu commented Sep 1, 2023

Check the list of all available partners' bounties.

When a bounty (i.e. issue) has the Unavailable label it means that the bounty is already assigned to some bounty hunter. We should hide such bounties from the list.

What should be done:

  • if bounty is unavailable (i.e. assigned to some bounty hunter) and does not exist in the list (i.e. first sync) then don't sync such bounty
  • if bounty is unavailable (i.e. assigned to some bounty hunter) and exists in the list with the state open then close such bounty
  • if bounty is available (i.e. not assigned to some bounty hunter) and exists in the list with the state closed then reopen such bounty
@devilkiller-ag
Copy link

Hi @rndquu Can I work on this issue?

Copy link

ubiquibot bot commented Nov 11, 2023

Available commands

- /start: Assign the origin sender to the issue automatically.
- /stop: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /autopay: Toggle automatic payment for the completion of the current issue.
- /query: Comments the users multiplier and address
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0x0000000000000000000000000000000000000000
  ex2: /wallet vitalik.eth

@devilkiller-ag

@rndquu
Copy link
Member Author

rndquu commented Nov 13, 2023

Hi @rndquu Can I work on this issue?

Hey, sure

@EtherealGlow
Copy link

How does devpool bounties sync all bounties, when does it know to run

@EtherealGlow
Copy link

@rndquu

@rndquu
Copy link
Member Author

rndquu commented Dec 30, 2023

How does devpool bounties sync all bounties, when does it know to run

This github workflow syncs bounties (i.e. github issues) every 15 minutes

@BeanieMen
Copy link

/start

@BeanieMen
Copy link

/assign

@BeanieMen
Copy link

ill just make the pr first i guess

@BeanieMen
Copy link

/stop

Copy link

ubiquibot bot commented Feb 27, 2024

! No assignees found for issue

@Keyrxng
Copy link

Keyrxng commented Mar 4, 2024

/start

Copy link

ubiquibot bot commented Mar 4, 2024

Warning! This task was created over 184 days ago. Please confirm that this issue specification is accurate before starting.
DeadlineMon, Mar 4, 4:25 PM UTC
Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquibot bot commented Mar 13, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Mar 13, 2024

[ 0.8 WXDAI ]

@BeanieMen
Contributions Overview
ViewContributionCountReward
IssueComment10.8
Conversation Incentives
CommentFormattingRelevanceReward
ill just make the pr first i guess...
0.80.330.8

[ 37.5 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueTask137.5

[ 35.6 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification131.8
IssueComment23.8
Conversation Incentives
CommentFormattingRelevanceReward
Check the [list](https://github.com/ubiquity/devpool-directory/i...
31.8
a:
  count: 2
  score: "2"
  words: 2
li:
  count: 3
  score: "3"
  words: 81
code:
  count: 3
  score: "3"
  words: 3
131.8
> Hi @rndquu Can I work on this issue?

Hey, sure...

0.40.10.4
> How does devpool bounties sync all bounties, when does it know...
3.4

a:
  count: 1
  score: "1"
  words: 1
0.593.4

[ 1.4 WXDAI ]

@EtherealGlow
Contributions Overview
ViewContributionCountReward
IssueComment21.4
Conversation Incentives
CommentFormattingRelevanceReward
How does devpool bounties sync all bounties, when does it know t...
1.30.811.3
@rndquu ...
0.10.470.1

@0x4007 0x4007 reopened this Mar 22, 2024
@0x4007
Copy link
Member

0x4007 commented Mar 22, 2024

This isn't working @rndquu @Keyrxng

This is currently assigned:

ubiquity/card-issuance#26

image

Public and private issues are affected.

@ubiquibot ubiquibot bot unassigned Keyrxng Mar 22, 2024
@rndquu
Copy link
Member Author

rndquu commented Mar 22, 2024

This isn't working @rndquu @Keyrxng

This is currently assigned:

ubiquity/card-issuance#26

Public and private issues are affected.

https://github.com/ubiquity/devpool-directory-private doesn't have the latest code from https://github.com/ubiquity/devpool-directory

https://github.com/ubiquity/devpool-directory-private should have been forked from https://github.com/ubiquity/devpool-directory, @devpanther could you fix it?

@devpanther
Copy link

Oh @rndquu, I've forgotten but something did not work when we forked.

Oh yeah, we can't private a fork of a public repo

@devpanther
Copy link

I don't have access to privates anymore

@rndquu
Copy link
Member Author

rndquu commented Mar 22, 2024

Oh @rndquu, I've forgotten but something did not work when we forked.

Oh yeah, we can't private a fork of a public repo

Did you try https://docs.github.com/en/repositories/creating-and-managing-repositories/duplicating-a-repository#mirroring-a-repository-in-another-location ?

@rndquu
Copy link
Member Author

rndquu commented Mar 22, 2024

I don't have access to privates anymore

ubiquity/work.ubq.fi#2 (comment)

You need write access to https://github.com/ubiquity/devpool-directory-private, right?

@devpanther
Copy link

I don't have access to privates anymore

ubiquity/work.ubq.fi#2 (comment)

You need write access to https://github.com/ubiquity/devpool-directory-private, right?

Yes

@rndquu
Copy link
Member Author

rndquu commented Mar 22, 2024

I don't have access to privates anymore

ubiquity/work.ubq.fi#2 (comment)
You need write access to https://github.com/ubiquity/devpool-directory-private, right?

Yes

Sent invite with write access to https://github.com/ubiquity/devpool-directory-private

@0x4007
Copy link
Member

0x4007 commented Mar 23, 2024

This needs to be addressed in time for the conference. @Keyrxng can you handle this?

Otherwise @ubiquity/software-development any takers?

@molecula451
Copy link
Member

what is the fuzz with this task, why it was reopened, it had 2 linked PRs assuming solving this issue?

@0x4007
Copy link
Member

0x4007 commented Mar 24, 2024

if bounty is unavailable (i.e. assigned to some bounty hunter) and exists in the list with the state open then close such bounty

This is not implemented correctly. I receive frequent complaints from new would-be candidates that its tedious to go through the devpool.directory and constantly have to sift through already assigned tasks.

This is especially relevant as we are hiring a team of developer relations managers to find devs at the upcoming conference this week, with their first point of entry being the devpool.directory

@rndquu
Copy link
Member Author

rndquu commented Mar 24, 2024

if bounty is unavailable (i.e. assigned to some bounty hunter) and exists in the list with the state open then close such bounty

This is not implemented correctly. I receive frequent complaints from new would-be candidates that its tedious to go through the devpool.directory and constantly have to sift through already assigned tasks.

This is especially relevant as we are hiring a team of developer relations managers to find devs at the upcoming conference this week, with their first point of entry being the devpool.directory

The is implemented correctly. As you already mentioned you see already assigned issues only from private repos.

TLDR;

  1. https://github.com/ubiquity/devpool-directory-private doesn't have the latest code, we're fixing it here
  2. This issue can be closed as completed

@0x4007
Copy link
Member

0x4007 commented Mar 25, 2024

The is implemented correctly. As you already mentioned you see already assigned issues only from private repos.

No my comment asserts that public and private repos are affected. Besides, I just checked again and the first task from a public repos is assigned.

image

image

@Keyrxng
Copy link

Keyrxng commented Mar 25, 2024

Open in UBQ devpool:

empty_string_unassigned


Open in Keyrxng devpool:

empty_string_k_devpool


I assigned myself it making it unavailable:

devpool_assigned


Closed in keyrxng devpool because it's now assigned

devpool_k_closed_because_assigned

@Keyrxng
Copy link

Keyrxng commented Mar 25, 2024

My current open PR against the devpool is the logic which ran to produce this result. However, the original issue was resolved according to the spec here and that was just to remove the unavailable bounties from the devpool repo was it not? The work UI interfacing was not part of this bounty

@0x4007
Copy link
Member

0x4007 commented Mar 25, 2024

However, the original issue was resolved according to the spec here and that was just to remove the unavailable bounties from the devpool repo was it not?

You're right. I read the following as "closing" the issue which means that it would not render in the work.ubq.fi UI

if bounty is unavailable (i.e. assigned to some bounty hunter) and exists in the list with the state open then close such bounty

With an emphasis on

then close such bounty

So we need to file a new issue and get a new pull request to actually close them?

@0x4007 0x4007 closed this as completed Mar 25, 2024
Copy link

ubiquibot bot commented Mar 25, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Mar 25, 2024

[ 21.2 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueComment521.2
Conversation Incentives
CommentFormattingRelevanceReward
This isn't working @rndquu @Keyrxng

This is currently assigned...

2.40.162.4
This needs to be addressed in time for the conference. @Keyrxng ...
2.10.562.1
> if bounty is unavailable (i.e. assigned to some bounty hunter)...
8.5

a:
  count: 2
  score: "2"
  words: 4
0.618.5
> The is implemented correctly. As you already mentioned you see...
2.60.5852.6
> However, the original issue was resolved according to the spec...
5.6
code:
  count: 1
  score: "1"
  words: 1
0.455.6

[ 2 WXDAI ]

@molecula451
Contributions Overview
ViewContributionCountReward
IssueComment12
Conversation Incentives
CommentFormattingRelevanceReward
what is the fuzz with this task, why it was reopened, it had 2 l...
20.472

[ 3.4 WXDAI ]

@devpanther
Contributions Overview
ViewContributionCountReward
IssueComment33.4
Conversation Incentives
CommentFormattingRelevanceReward
Oh @rndquu, I've forgotten but something did not work when we fo...
2.50.162.5
I don't have access to privates anymore ...
0.80.270.8
> > I don't have access to privates anymore > > https://github....
0.10.30.1

[ 0.8 WXDAI ]

@BeanieMen
Contributions Overview
ViewContributionCountReward
IssueComment10.8
Conversation Incentives
CommentFormattingRelevanceReward
ill just make the pr first i guess...
0.80.230.8

[ 10.3 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueComment210.3
Conversation Incentives
CommentFormattingRelevanceReward
# Open in UBQ devpool:

![empty_string_unassigned](https://git...

3.7

h1:
  count: 4
  score: "1"
  words: 24
0.53.7
- https://github.com/ubiquity/devpool-directory/pull/1145

My ...

6.6

li:
  count: 1
  score: "0.25"
  words: 8
code:
  count: 1
  score: "0.25"
  words: 1
0.5956.6

[ 72.6 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification131.8
IssueComment740.8
Conversation Incentives
CommentFormattingRelevanceReward
Check the [list](https://github.com/ubiquity/devpool-directory/i...
31.8
a:
  count: 2
  score: "2"
  words: 2
li:
  count: 3
  score: "3"
  words: 81
code:
  count: 3
  score: "3"
  words: 3
131.8
> Hi @rndquu Can I work on this issue?

Hey, sure...

0.40.130.4
> How does devpool bounties sync all bounties, when does it know...
3.4

a:
  count: 1
  score: "1"
  words: 1
0.243.4
> This isn't working @rndquu @Keyrxng > > This is currently a...
9.6
a:
  count: 1
  score: "1"
  words: 4
0.199.6
> Oh @rndquu, I've forgotten but something did not work when we ...
4.40.44.4
> I don't have access to privates anymore

https://github.com/...

4.80.564.8
> > > I don't have access to privates anymore

[...

3.6

a:
  count: 1
  score: "1"
  words: 6
0.443.6
> > if bounty is unavailable (i.e. assigned to some bounty hunte...
14.6
a:
  count: 4
  score: "4"
  words: 6
li:
  count: 2
  score: "2"
  words: 39
0.5114.6

[ 1.4 WXDAI ]

@EtherealGlow
Contributions Overview
ViewContributionCountReward
IssueComment21.4
Conversation Incentives
CommentFormattingRelevanceReward
How does devpool bounties sync all bounties, when does it know t...
1.30.081.3
@rndquu ...
0.10.370.1

@Keyrxng
Copy link

Keyrxng commented Mar 25, 2024

However, the original issue was resolved according to the spec here and that was just to remove the unavailable bounties from the devpool repo was it not?

You're right. I read the following as "closing" the issue which means that it would not render in the work.ubq.fi UI

if bounty is unavailable (i.e. assigned to some bounty hunter) and exists in the list with the state open then close such bounty

With an emphasis on

then close such bounty

So we need to file a new issue and get a new pull request to actually close them?

Sorry confused that PR with the decimals one but once the next action run happens im certain that decimals will be closed,

Although the QA I presented and if you check the devpool, it states this issue is closed and you have just left a comment on the PR associated with it

@rndquu
Copy link
Member Author

rndquu commented Mar 26, 2024

FYI current issue (hiding unavailable bounties) works as expected in ubiquity/devpool-directory#1145

@0x4007
Copy link
Member

0x4007 commented Mar 26, 2024

FYI current issue (hiding unavailable bounties) works as expected in ubiquity/devpool-directory#1145

I see, thanks for highlighting this.

The proper form of delivery would require cherry picking changes and associating them with a task to be eligible for the reward.

@Keyrxng
Copy link

Keyrxng commented Mar 26, 2024

Hiding the unavailable bounties was implemented correctly when rndquu closed this as completed. I just deleted all issues and then checked-out from the merge commit with the only change being commenting out the twitter stuff and no unavailable labels or assigned issues exist in my devpool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants