Update mapping files for ocular phenotypes #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ficolo
approved these changes
May 28, 2024
There was a problem hiding this comment.
🙏🏻 this one is new! Good catch.
There was a problem hiding this comment.
Hopefully we won't need to run this script every release.
ficolo
approved these changes
May 28, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77.
I added a module which takes file from IMPRESS and modifies the mapping files in the pipeline according to it, so that all parameters are included.
I assume that the same parameter value has the same meaning between different centres. For example, I don't have values for RBRCLA_EYE_003_001 as it's a new parameter, but I'm using the same parameter interpretations as for IMPC_EYE_003_001: