Fix timeout value in std output #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the wrong timeout in the terminal output there.
github-actions
bot
requested review from
aprotyas,
bmagyar,
christophfroehlich,
DasRoteSkelett,
destogl,
erickisos and
saikishor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1807 +/- ##
==========================================
- Coverage 87.62% 87.60% -0.02%
==========================================
Files 120 120
Lines 12217 12223 +6
Branches 1093 1093
==========================================
+ Hits 10705 10708 +3
- Misses 1123 1125 +2
- Partials 389 390 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
We were using the wrong timeout in the terminal output there. (cherry picked from commit cb91599) # Conflicts: # controller_manager/controller_manager/controller_manager_services.py
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
We were using the wrong timeout in the terminal output there. (cherry picked from commit cb91599) # Conflicts: # controller_manager/controller_manager/controller_manager_services.py
This was referenced Oct 25, 2024
christophfroehlich
added a commit
that referenced
this pull request
Oct 25, 2024
* Fix timeout value in std output (#1807) We were using the wrong timeout in the terminal output there. (cherry picked from commit cb91599) # Conflicts: # controller_manager/controller_manager/controller_manager_services.py * Update controller_manager_services.py --------- Co-authored-by: Felix Exner (fexner) <exner@fzi.de> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich
added a commit
that referenced
this pull request
Oct 25, 2024
* Fix timeout value in std output (#1807) We were using the wrong timeout in the terminal output there. (cherry picked from commit cb91599) # Conflicts: # controller_manager/controller_manager/controller_manager_services.py * Update controller_manager_services.py --------- Co-authored-by: Felix Exner (fexner) <exner@fzi.de> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the wrong timeout in the terminal output there.
As pointed out in #1501 (comment)
Thanks @tonynajjar for spotting this!