Add service call timeout argument in spawner #1808
Open
+97
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2024 12:02
Signed-off-by: Angsa Deployment Team <team@angsa-robotics.com>
Signed-off-by: Angsa Deployment Team <team@angsa-robotics.com>
github-actions
bot
requested review from
bijoua29,
bmagyar,
christophfroehlich,
destogl,
erickisos,
livanov93 and
olivier-stasse
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1808 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 121 121
Lines 12317 12319 +2
Branches 1095 1095
=======================================
+ Hits 10868 10870 +2
Misses 1055 1055
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
requested changes
Oct 25, 2024
There was a problem hiding this comment.
LGTM, but please rebase/merge on master and update the release_notes and docs as I've done in this PR.
Done. I believe CI is failing not because of this PR |
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the call_timeout of the spawner to be optionally set by the user