Use Clock instead of Rate for backward compatibility of rolling #1864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently merged : #1810 breaks the backward compatibility of rolling in Humble, as the Humble rclcpp doesn't have the implementation of the Rate using Clock -> https://github.com/ros2/rclcpp/blob/humble/rclcpp/include/rclcpp/rate.hpp#L115
This PR proposes a fix by using the Clock's
sleep_until
method which is backward compatible and works the same