Skip to content

Conversation

saikishor
Copy link
Member

Fixes #2336

This is done as an exception against the meaning of the period, so that the controllers won't have to repeat the operation again internally. It would also be easier to integrate with the PIDs internally.

Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.30%. Comparing base (56fc052) to head (64b9ecb).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2572      +/-   ##
==========================================
- Coverage   89.31%   89.30%   -0.01%     
==========================================
  Files         145      145              
  Lines       16541    16538       -3     
  Branches     1396     1396              
==========================================
- Hits        14773    14770       -3     
  Misses       1231     1231              
  Partials      537      537              
Flag Coverage Δ
unittests 89.30% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 75.13% <100.00%> (-0.05%) ⬇️
...ontroller_manager/test/test_controller_manager.cpp 95.54% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikishor saikishor moved this to Kilted in Roadmap / Features Sep 24, 2025
@saikishor saikishor added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Oct 2, 2025
@bmagyar bmagyar merged commit 6077af4 into ros-controls:master Oct 2, 2025
27 of 29 checks passed
@bmagyar bmagyar deleted the get/valid_period/first_controller_update_cycle branch October 2, 2025 07:43
@github-project-automation github-project-automation bot moved this from Kilted to Done in Roadmap / Features Oct 2, 2025
mergify bot pushed a commit that referenced this pull request Oct 2, 2025
mergify bot pushed a commit that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Period is zero at first loop of ros controller

3 participants