Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Fix for the broken mimic joint where only 1 of the 2 gripper finger would move.
The support for mimic has been fixed for some time with this PR ros-controls/gazebo_ros2_control#107 and it shows that the mimic joint specification was missing from the ros2_control specification.
The first commit adds the specification and allows the gripper to be controlled properly
However, while the gripper works with moveit2 after this first commit, a bunch of error messages are generated at runtime:
[move_group-3] [ERROR] [1692102600.709104192] [moveit_robot_model.robot_model]: Joint 'crane_x7_gripper_finger_b_joint_mimic' not found in model 'crane_x7'
The second commit adds a dummy joint to prevent this. This is only a workaround (suggested here: ros-controls/gazebo_ros2_control#173.
There might be some more elegant solution and possible resolution is still discussed
ROBOTIS-GIT/turtlebot3_manipulation#66
ros-controls/gz_ros2_control#96
Does this close any currently open issues?
Fixes rt-net/crane_x7_ros#161
How has this been tested?
By running
ros2 launch crane_x7_gazebo crane_x7_with_table.launch.py
and planning arm/gripper control from RViz/MoveitAny other comments?
The automatic test suite via github workflow seems to fail on our fork, however it looks unrelated to the change.
Checklists