-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write specs for new Ruby 3.0 features and changes #823
Comments
I think this is already covered and can be marked completed:
spec/core/symbol/to_proc_spec.rb Lines 32 to 37 in 7526ccb
|
Revised the "Language changes" and "Core classes updates" sections and marked items that are already tested. |
Thanks! |
Hi! It looks like already done by this commit 1093159 |
@moofkit Yes, but that change doesn't check there is no warning in 3.0+ for regular pattern matching (1-line pattern matching is still experimental in 3.0). Could you add a spec in that file that check |
I'll take on a few pattern matching items:
|
Will wait to go after Feature #16828 until I understand conventions for contributing to this repo. |
Refers to ruby#823 Adds specs for Feature#16828, the find pattern, (`[1, 2, 3] in [*pre, 2, *post]`) in Ruby 3.0+.
Feature#16378 (Argument forwarding with leading arg) had been completed by the following commit: |
Refers to #823 Adds specs for Feature#16828, the find pattern, (`[1, 2, 3] in [*pre, 2, *post]`) in Ruby 3.0+.
Covering "Hash#transform_keys({old_key: new_key}) from ruby#823 Hash#transform_keys and Hash#transform_keys! now accept a hash that maps keys to new keys. [Feature #16274]
@JuanCrg90 Thanks! I noted those as done. |
Covering "Hash#transform_keys({old_key: new_key}) from ruby#823 Hash#transform_keys and Hash#transform_keys! now accept a hash that maps keys to new keys. [Feature #16274]
Was already implemented on: 05ff9d434c |
Covering "Hash#transform_keys({old_key: new_key}) from #823 Hash#transform_keys and Hash#transform_keys! now accept a hash that maps keys to new keys. [Feature #16274]
@marcandre I wonder, do you have specs for Ractor? |
@eregon, oops, missed that notification, sorry. Yes, I used CRuby tests to check my backport (and I was glad to have them all pass, except those that were checking that |
The "Core classes updates" has two sections named "Fiber". The second one is in between "Symbol" and "Thread". |
ruby/spec already contains some specs for 3.0, but we should aim to cover all new features and important changes.
This will improve the test coverage of these features (and maybe discover a few bugs along the way), allow other Ruby implementations to implement the changes faster with more confidence and document clearly the new behavior.
The new specs should be within a version guard block:
NOTE: https://rubyreferences.github.io/rubychanges/3.0.html gives more details for many features and changes.
From https://github.com/ruby/ruby/blob/master/doc/NEWS-3.0.0.md:
NEWS for Ruby 3.0.0
This document is a list of user visible feature changes
since the 2.7.0 release, except for bug fixes.
Note that each entry is kept to a minimum, see links for details.
Language changes
Keyword arguments are now separated from positional arguments.
Code that resulted in deprecation warnings in Ruby 2.7 will now
result in ArgumentError or different behavior. [Feature #14183]
Procs accepting a single rest argument and keywords are no longer
subject to autosplatting. This now matches the behavior of Procs
accepting a single rest argument and no keywords.
[Feature #16166]
Arguments forwarding (
...
) now supports leading arguments.[Feature #16378]
Pattern matching (
case/in
) is no longer experimental. [Feature #17260]One-line pattern matching is redesigned. [EXPERIMENTAL]
=>
is added. It can be used like a rightward assignment.[Feature #17260]
in
is changed to returntrue
orfalse
. [Feature #17371]Find-pattern is added. [EXPERIMENTAL]
[Feature #16828]
Endless method definition is added. [EXPERIMENTAL]
[Feature #16746]
Interpolated String literals are no longer frozen when
# frozen-string-literal: true
is used. [Feature #17104]Magic comment
shareable_constant_value
added to freeze constants.See {Magic Comments}[rdoc-ref:doc/syntax/comments.rdoc@Magic+Comments] for more details.
[Feature #17273]
Deprecation warnings are no longer shown by default (since Ruby 2.7.2).
Turn them on with
-W:deprecated
(or with-w
to show other warnings too).[Feature #16345]
$SAFE
and$KCODE
are now normal global variables with no special behavior.C-API methods related to
$SAFE
have been removed.[Feature #16131] [Feature #17136]
yield in singleton class definitions in methods is now a SyntaxError
instead of a warning. yield in a class definition outside of a method
is now a SyntaxError instead of a LocalJumpError. [Feature #15575]
When a class variable is overtaken by the same definition in an
ancestor class/module, a RuntimeError is now raised (previously,
it only issued a warning in verbose mode). Additionally, accessing a
class variable from the toplevel scope is now a RuntimeError.
[Bug #14541]
(to be sync'd from truffleruby) Assigning to a numbered parameter is now a SyntaxError instead of
a warning.
Command line options
--help
optionRUBY_PAGER
orPAGER
is present and hasa non-empty value, and the standard input and output are tty, the
--help
option shows the help message via the pager designated by the value.
[Feature #16754]
--backtrace-limit
option--backtrace-limit
option limits the maximum length of a backtrace.[Feature #8661]
Core classes updates
Outstanding ones only.
Array
The following methods now return Array instances instead of
subclass instances when called on subclass instances:
[Bug #6087]
Can be sliced with Enumerator::ArithmeticSequence
Binding
"(eval)"
for
__FILE__
and1
for__LINE__
in the evaluated code.[Bug #4352] [Bug #17419]
ConditionVariable
block
/unblock
schedulerhooks in a non-blocking context. [Feature #16786]
Dir
accept the
sort:
keyword option. [Feature #8709]ENV
ENV.except has been added, which returns a hash excluding the
given keys and their values. [Feature #15822]
Windows: Read ENV names and values as UTF-8 encoded Strings
[Feature #12650]
Encoding
Added new encoding IBM720. [Feature #16233]
Changed default for Encoding.default_external to UTF-8 on Windows
[Feature #16604]
Fiber
Fiber.new(blocking: true/false) allows you to create non-blocking
execution contexts. [Feature #16786]
Fiber#blocking? tells whether the fiber is non-blocking. [Feature #16786]
Fiber#backtrace and Fiber#backtrace_locations provide per-fiber backtrace.
[Feature #16815]
The limitation of Fiber#transfer is relaxed. [Bug #17221]
GC
when compaction runs. Setting
auto_compact=
totrue
will causecompaction to occur during major collections. At the moment,
compaction adds significant overhead to major collections, so please
test first! [Feature #17176]
Hash
Hash#transform_keys and Hash#transform_keys! now accept a hash that maps
keys to new keys. [Feature #16274]
Hash#except has been added, which returns a hash excluding the
given keys and their values. [Feature #15822]
IO
IO#nonblock? now defaults to
true
. [Feature #16786]@aardvark179 IO#wait_readable, IO#wait_writable, IO#read, IO#write and other
related methods (e.g. IO#puts, IO#gets) may invoke the scheduler hook
#io_wait(io, events, timeout)
in a non-blocking execution context.[Feature #16786]
Kernel
Kernel#clone when called with the
freeze: false
keyword will call#initialize_clone
with thefreeze: false
keyword.[Bug #14266]
Kernel#clone when called with the
freeze: true
keyword will call#initialize_clone
with thefreeze: true
keyword, and willreturn a frozen copy even if the receiver is unfrozen.
[Feature #16175]
Kernel#eval when called with two arguments will use
"(eval)"
for
__FILE__
and1
for__LINE__
in the evaluated code.[Bug #4352]
(added in truffleruby) Kernel#lambda now warns if called without a literal block.
[Feature #15973]
@aardvark179 Kernel.sleep invokes the scheduler hook
#kernel_sleep(...)
in anon-blocking execution context. [Feature #16786]
Module
Module#include and Module#prepend now affect classes and modules
that have already included or prepended the receiver, mirroring the
behavior if the arguments were included in the receiver before
the other modules and classes included or prepended the receiver.
[Feature #9573]
Module#public, Module#protected, Module#private, Module#public_class_method,
Module#private_class_method, toplevel "private" and "public" methods
now accept single array argument with a list of method names. [Feature #17314]
Module#attr_accessor, Module#attr_reader, Module#attr_writer and Module#attr
methods now return an array of defined method names as symbols.
[Feature #17314]
Module#alias_method now returns the defined alias as a symbol.
[Feature #17314]
Mutex
Mutex
is now acquired per-Fiber
instead of per-Thread
. This changeshould be compatible for essentially all usages and avoids blocking when
using a scheduler. [Feature #16792]
Proc
separate Proc instances if the procs were created from the same block.
[Feature #14267]
Queue / SizedQueue
block
/unblock
scheduler hooks in a non-blocking context.[Feature #16786]
Ractor
more details.
Random
Random::DEFAULT
now refers to theRandom
class instead of being aRandom
instance,so it can work with
Ractor
.[Feature #17322]
Random::DEFAULT
is deprecated since its value is now confusing and it is no longer global,use
Kernel.rand
/Random.rand
directly, or create aRandom
instance withRandom.new
instead.[Feature #17351]
String
The following methods now return or yield String instances
instead of subclass instances when called on subclass instances:
[Bug #10845]
Symbol
Symbol#to_proc now returns a lambda Proc. [Feature #16260]
Symbol#name has been added, which returns the name of the symbol
if it is named. The returned string is frozen. [Feature #16150]
Fiber
@aardvark179 Introduce Fiber.set_scheduler for intercepting blocking operations and
Fiber.scheduler for accessing the current scheduler. See
rdoc-ref:fiber.md for more details about what operations are supported and
how to implement the scheduler hooks. [Feature #16786]
Fiber.blocking? tells whether the current execution context is
blocking. [Feature #16786]
@aardvark179 Thread#join invokes the scheduler hooks
block
/unblock
in anon-blocking execution context. [Feature #16786]
Thread
default deadlock detection, allowing the use of signal handlers to
break deadlock. [Bug #13768]
Warning
[Feature #17122]
Stdlib updates
Set
SortedSet has been removed for dependency and performance reasons.
Set#join is added as a shorthand for
.to_a.join
.Set#<=> is added.
Socket
Compatibility issues
Excluding feature bug fixes.
Regexp literals and all Range objects are frozen. [Feature #8948] [Feature #16377] [Feature #15504]
EXPERIMENTAL: Hash#each consistently yields a 2-element array. [Bug #12706]
{ a: 1 }.each(&->(k, v) { })
raises an ArgumentErrordue to lambda's arity check.
When writing to STDOUT redirected to a closed pipe, no broken pipe
error message will be shown now. [Feature #14413]
TRUE
/FALSE
/NIL
constants are no longer defined.Integer#zero? overrides Numeric#zero? for optimization. [Misc #16961]
Enumerable#grep and Enumerable#grep_v when passed a Regexp and no block no longer modify
Regexp.last_match. [Bug #17030]
Requiring 'open-uri' no longer redefines
Kernel#open
.Call
URI.open
directly oruse URI#open
instead. [Misc #15893]SortedSet has been removed for dependency and performance reasons.
Stdlib compatibility issues
Default gems
The following libraries are promoted to default gems from stdlib.
The following extensions are promoted to default gems from stdlib.
Bundled gems
If you are interested in maintaining them, please comment on
your plan to https://github.com/ruby/xmlrpc
or https://github.com/ruby/net-telnet.
SDBM has been removed from the Ruby standard library. [Bug #8446]
WEBrick has been removed from the Ruby standard library. [Feature #17303]
C API updates
C API functions related to
$SAFE
have been removed.[Feature #16131]
C API header file
ruby/ruby.h
was split. [GH-2991]This should have no impact on extension libraries,
but users might experience slow compilations.
Memory view interface [EXPERIMENTAL]
such as a numeric array or a bitmap image, between extension libraries.
The extension libraries can share also the metadata of the memory area
that consists of the shape, the element format, and so on.
Using these kinds of metadata, the extension libraries can share even
a multidimensional array appropriately.
This feature is designed by referring to Python's buffer protocol.
[Feature #13767] [Feature #14722]
Ractor related C APIs are introduced (experimental) in "include/ruby/ractor.h".
Implementation improvements
New method cache mechanism for Ractor. [Feature #16614]
in parallel and synchronization is needed even for method caches. However,
such synchronization can be overhead so introducing new inline method cache
mechanisms, (1) Disposable inline method cache (2) per-Class method cache
and (3) new invalidation mechanism. (1) can avoid per-method call
synchronization because it only uses atomic operations.
See the ticket for more details.
The number of hashes allocated when using a keyword splat in
a method call has been reduced to a maximum of 1, and passing
a keyword splat to a method that accepts specific keywords
does not allocate a hash.
super
is optimized when the same type of method is called in the previous callif it's not refinements or an attr reader or writer.
Miscellaneous changes
Methods using
ruby2_keywords
will no longer keep empty keywordsplats, those are now removed just as they are for methods not
using
ruby2_keywords
.(seems untestable as 2.7 would only order reversed if TTY) When an exception is caught in the default handler, the error
message and backtrace are printed in order from the innermost.
[Feature #8661]
(to be sync'd from truffleruby) Accessing an uninitialized instance variable no longer emits a
warning in verbose mode. [Feature #17055]
The text was updated successfully, but these errors were encountered: