Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(hmi) QRCodeDecoder #41

Merged
merged 32 commits into from
May 14, 2024
Merged

(hmi) QRCodeDecoder #41

merged 32 commits into from
May 14, 2024

Conversation

P-ict0
Copy link
Contributor

@P-ict0 P-ict0 commented Feb 29, 2024

After merge, merge also robot launch files PR and hero_bringup PR

Adds QR code reading functionality to hero as a wrapper for an HMI server.
Aimed for GPSR and EGPSR.

ToDo:

  • Remove hardcoded 'hero' from topic list
  • Read qr code x times to verify the data
  • Check how much of the screen the qr code takes up (to not have false positives)
  • Add maximum tries
  • Add pyzbar to the dependencies
  • Add to lauchfile

@P-ict0 P-ict0 self-assigned this Feb 29, 2024
@P-ict0 P-ict0 marked this pull request as ready for review March 19, 2024 18:28
@P-ict0 P-ict0 changed the title (hmi) Draft of QRCodeDecoder (hmi) QRCodeDecoder Mar 19, 2024
Copy link
Member

@MatthijsBurgh MatthijsBurgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully typed, black And why is the grammar file there?

@P-ict0 P-ict0 marked this pull request as draft March 19, 2024 20:14
@MatthijsBurgh
Copy link
Member

I don't want a black commit, run black on each commit. With line length of 120.

@P-ict0 P-ict0 marked this pull request as ready for review May 7, 2024 17:04
MatthijsBurgh
MatthijsBurgh previously approved these changes May 7, 2024
@MatthijsBurgh MatthijsBurgh merged commit 1b30dd9 into master May 14, 2024
4 checks passed
@MatthijsBurgh MatthijsBurgh deleted the feat/qr-code-reader branch May 14, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants